Automated Drupal 10 compatibility fixes

Hi,

I tested the patch #2 and it work as expected.

Looks fine to me! Can it be released soon?

+ 1 for releasing D10 version.

I am getting an error with the patch #2:

Error: Cannot use object of type Drupal\Core\StringTranslation\TranslatableMarkup as array in Drupal\Core\Render\Renderer->doRender()

triggered by Drupal\views_arg_order_sort\Plugin\views\sort\ArgOrderSort->buildOptionsForm() (line 43). $data['table']['group'] and $f['title'] are just translatable markups, why do we need to run the renderer at all?

I applied patch#10 this works for Drupal 9.5.10 and Drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5 have been attached for reference:

Can be move to RTBC+1

Hi, can patch from #10 been merged + a new D10 compatible version been created?

#10 works for me in D10.2.1 with PHP 8.3.0, along with the patch at Fix PHP 8.2 warnings 🐛 Fix PHP 8.2 warnings RTBC .

If you want to install these with Composer while we wait for a new release, you can put these entries in your composer.json file:

{
    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/views_arg_order_sort"
            ]
        },
        {
            "type": "package",
            "package": {
                "name": "drupal-gitlab/views_arg_order_sort",
                "type": "drupal-module",
                "version": "dev-2.x",
                "source": {
                    "type": "git",
                    "url": "https://git.drupalcode.org/project/views_arg_order_sort.git",
                    "reference": "2.x"
                }
            }
        }
    ],
    "require": {
        "cweagans/composer-patches": "^1.7",
        "drupal-gitlab/views_arg_order_sort": "dev-2.x"
    },
    "config": {
        "allow-plugins": {
            "cweagans/composer-patches": true
        }
    },
    "extra": {
        "enable-patching": true,
        "composer-exit-on-patch-failure": true,
        "patchLevel": {
            "drupal/core": "-p2"
        },
        "patches": {
            "drupal-gitlab/views_arg_order_sort": {
                "D10 compatibility. See https://www.drupal.org/project/views_arg_order_sort/issues/3299435": "https://www.drupal.org/files/issues/2023-10-27/views_arg_order_sort-drupal10-compatibility-3299435-10.patch",
                "Fix PHP 8.2 warnings. See https://www.drupal.org/project/views_arg_order_sort/issues/3388655": "https://www.drupal.org/files/issues/2023-09-20/remove-php8.2-warnings.patch"
            }
        }
    }
}

Automatically closed - issue fixed for 2 weeks with no activity.