- ๐ฎ๐ณIndia Vishal Choudhary Dharmshala
Hi, Team I have compatible with this module in Drupal 10 and I have tested this module in our local D10 Setup and It's working Fine. So I have attached the Patch file and screenshot of the compatible version.
Thanks. - Status changed to RTBC
over 1 year ago 7:21am 3 April 2023 - ๐ฎ๐ณIndia dineshkumarbollu
Hi
I reviewed the patch it applied cleanly and shows 0 compatible issues using upgrade status module report.
I am attaching screenshot of upgrade status report. - ๐ซ๐ทFrance bernard63
I applied the patches you indicate and use the VAPN module on my local development site (xampp).
So far everything works fine with D10.0.9.
thank you for all your work
best regards - Status changed to Needs review
over 1 year ago 10:37am 24 June 2023 This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module โ , even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.
Therefore this patch does not update the
info.yml
file for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot โ to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #12554This patch was created using these packages:
- mglaman/phpstan-drupal: 1.1.35
- palantirnet/drupal-rector: 0.15.1
- ๐ฎ๐ณIndia latha@dc
nagalatha_gampa โ made their first commit to this issueโs fork.
- ๐ต๐ชPeru alyaj2a
I used patch #9 ๐ Automated Drupal 10 compatibility fixes Fixed and it installed fine, the detail is when you don't configure it, anonymously I get an error which I adjusted with a validation, I don't know if it's the right way. Help!.
- Status changed to RTBC
over 1 year ago 12:43pm 17 September 2023 - ๐ฌ๐งUnited Kingdom andybroomfield
I have reviewed this in a fresh install on Drupal 10 (using the composer drupal lenient plugin) and then applied the patch in #11.
I tested assigning VAPN to a basic page and then verifying that only users with the appropriate role could access the selected content.I'd be happy for this to be merged for Drupal 10.
- ๐ฌ๐งUnited Kingdom Alina Basarabeanu
The patch from #11 is working as expected on Drupal Version 9.5.11 but the Upgrade status shows 1 problem Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055 โ , which includes recommendations on which theme to use.
- First commit to issue fork.
- @andrechun opened merge request.
-
andrechun โ
committed 98ad5233 on 8.x-1.x
Resolve #3299404 "D10 compatible"
-
andrechun โ
committed 98ad5233 on 8.x-1.x
- ๐ฏ๐ตJapan andrechun
The code is already committed but I don't have access to release it. I contacted the module's owner to create a new release.
- ๐ฌ๐งUnited Kingdom davej
The change to src/vapnHandler.php in https://git.drupalcode.org/project/vapn/-/merge_requests/6/diffs looks odd to me, itโs inserting a function header phpdoc comment into the middle of a function. This comment refers to a variable $node that doesnโt occur in the function and says "Some function description". Looks like this comes from patch #6 .
- ๐ฏ๐ตJapan andrechun
@davej Thank you for spotting the error. I now removed the comment and added a few other minor fixes: https://git.drupalcode.org/project/vapn/-/commit/5b4fac23a28816f1883d6a4...
- Status changed to Fixed
about 1 year ago 9:49am 22 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.