Open page callback found, please add a comment before the line why there is no access restriction

Created on 21 July 2022, over 2 years ago
Updated 17 August 2024, 3 months ago

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\mailsystem\tests\modules\mailsystem_test\mailsystem_test.routing.yml
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
9 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
-----------------------------------------------------------------------------------------------------------------------

📌 Task
Status

Needs work

Version

4.0

Component

Code

Created by

🇮🇳India Harsh panchal

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇹Italy apaderno Brescia, 🇮🇹
         no_cache: 'TRUE'
       requirements:
    +   # Please add comment manually here.
         _access: 'TRUE'
    

    The report clearly states: Please add a comment before the line [explaining] why there is no access restriction. Please add comment manually here. does not explain whey there is not access restriction: It just a workaround to avoid phpcs complains.
    At this point, it would be better to ignore the report, which is given for a test module.

  • Status changed to Needs review 12 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 12 months ago
    4 pass
  • 🇮🇳India adwivedi008

    @apaderno I have revised #2 and I have covered the points mentioned above

    Please review, moving the issue to "needs review".

  • Status changed to Needs work 6 months ago
  • 🇨🇭Switzerland berdir Switzerland

    Should be done as a merge request, space missing after ,

  • First commit to issue fork.
Production build 0.71.5 2024