Create a micon linkit connection module

Created on 20 July 2022, almost 3 years ago
Updated 10 January 2024, over 1 year ago

Problem/Motivation

Provide a micon linkit connection module, to enable icons on link fields using linkit.

NOTE, that this functionality used to exist in older versions of micon under the name of "micon_linkit", but has been removed as of #3273973: Make Micon Linkit Widget compatible with Linkit:^5 || ^6 , since this submodule relied on a linkit patch and not the actual core module functionality (See patch from Linkit for Link field Fixed ).

Proposed resolution

As soon as Linkit for Link field Fixed is fixed, we can readd this functionality into micon.

Feature request
Status

Postponed

Version

2.1

Component

Code

Created by

🇩🇪Germany Grevil

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Composer require failure
  • 🇳🇱Netherlands watergate

    I've updated the merge request so that this Micon Linkit sub-module is installable on Drupal 10. I've mimicked the Micon Link module's core_version_requirement, as this is a dependency.

    Do I understand correctly that this issue is not postponed as Linkit for Link field Fixed is fixed?

  • Status changed to Active over 1 year ago
  • 🇩🇪Germany Grevil

    Thanks! Yea, the blocking issue seems to be fixed!

    I currently don't have the time to have a look at this again. Is this ready to review @Watergate? Setting back to "Active" for now.

  • Status changed to Needs review about 1 year ago
  • 🇳🇱Netherlands watergate

    I've updated the merge request by restoring the \Drupal\micon_link\Plugin\Field\FieldWidget\MiconLinkWidgetTrait trait. In the latest release, the functionality of that trait was added directly in the \Drupal\micon_link\Plugin\Field\FieldWidget\MiconLinkWidget widget, but this was also used by the \Drupal\micon_linkit\Plugin\Field\FieldWidget\MiconLinkitWidget widget.

    @Grevil, I've changed the ticket to "Needs review" (we use this functionality without problems).

  • 🇩🇪Germany Anybody Porta Westfalica

    @Grevil: We're now in need for a solution ourselves. We'd like to use linkit field widget instead of Link (Symbol) field widget, because Linkit provides a huge better UX (See our internal ticket).

    A bonus would be, if we could also make it compatible with Link Attributes: Add support for Linkit for Link field Fixed

    So eventually this may end up in two lightweight submodules. One providing integration with only Linkit (dependency) and one with Linkit and link_attributes (dependencies) that also offers attributes besides the symbol?

  • 🇩🇪Germany Anybody Porta Westfalica
  • Assigned to Grevil
  • Status changed to Needs work 22 days ago
  • 🇩🇪Germany Grevil

    At first I wanted to vote against splitting the functionality in 2 seperate modules. But we already have a split for link supporting submodules (micon_link and micon_linkit), so another micon_linkit_attributes submodule wouldn't be too much I guess.

  • 🇩🇪Germany Grevil

    All done, please review!

  • 🇩🇪Germany Anybody Porta Westfalica

    Nice work @Grevil. Some final additions and please check code-style. The complaints look weird to me, but we should ensure code style is fine! :)

  • 🇩🇪Germany Anybody Porta Westfalica
  • 🇩🇪Germany Grevil

    Problem was the composer.json.

    This will probably be better now, let's wait for the ci.

    • grevil committed 64bb7426 on 2.x
      Issue #3298600 by grevil, watergate, anybody: Create a micon + linkit (...
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024