- First commit to issue fork.
- last update
over 1 year ago Composer require failure - 🇳🇱Netherlands watergate
I've updated the merge request so that this Micon Linkit sub-module is installable on Drupal 10. I've mimicked the Micon Link module's
core_version_requirement
, as this is a dependency.Do I understand correctly that this issue is not postponed as ✨ Linkit for Link field Fixed is fixed?
- Status changed to Active
over 1 year ago 7:57am 11 January 2024 - 🇩🇪Germany Grevil
Thanks! Yea, the blocking issue seems to be fixed!
I currently don't have the time to have a look at this again. Is this ready to review @Watergate? Setting back to "Active" for now.
- Status changed to Needs review
about 1 year ago 8:52am 9 April 2024 - 🇳🇱Netherlands watergate
I've updated the merge request by restoring the
\Drupal\micon_link\Plugin\Field\FieldWidget\MiconLinkWidgetTrait
trait. In the latest release, the functionality of that trait was added directly in the\Drupal\micon_link\Plugin\Field\FieldWidget\MiconLinkWidget
widget, but this was also used by the\Drupal\micon_linkit\Plugin\Field\FieldWidget\MiconLinkitWidget
widget.@Grevil, I've changed the ticket to "Needs review" (we use this functionality without problems).
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: We're now in need for a solution ourselves. We'd like to use linkit field widget instead of Link (Symbol) field widget, because Linkit provides a huge better UX (See our internal ticket).
A bonus would be, if we could also make it compatible with Link Attributes: ✨ Add support for Linkit for Link field Fixed
So eventually this may end up in two lightweight submodules. One providing integration with only Linkit (dependency) and one with Linkit and link_attributes (dependencies) that also offers attributes besides the symbol?
- Assigned to Grevil
- Status changed to Needs work
22 days ago 2:08pm 28 April 2025 - 🇩🇪Germany Grevil
At first I wanted to vote against splitting the functionality in 2 seperate modules. But we already have a split for link supporting submodules (micon_link and micon_linkit), so another micon_linkit_attributes submodule wouldn't be too much I guess.
- 🇩🇪Germany Anybody Porta Westfalica
Nice work @Grevil. Some final additions and please check code-style. The complaints look weird to me, but we should ensure code style is fine! :)
- 🇩🇪Germany Grevil
Problem was the composer.json.
This will probably be better now, let's wait for the ci.
Automatically closed - issue fixed for 2 weeks with no activity.