- π¨π¦Canada iStryker
Needs core_version_requirement: ^8 || ^9 || ^10 in info file as will. Module should have a 2.0.x branch as there currently is none
- Status changed to Needs review
almost 2 years ago 10:29pm 8 February 2023 - πΊπΈUnited States dmundra Eugene, OR
Hi @IStryker,
I am actually waiting for the parent module to release a D10 version https://www.drupal.org/project/simplesamlphp_auth β then we can apply this patch and also release a version that is compatible with the newer version of simplesamlphp_auth.
- π¨π¦Canada iStryker
Okay. That does make sense. Is it possible to get the patch into a dev branch so at least the dev branch is d10 compatible.
- Assigned to dmundra
- πΊπΈUnited States dmundra Eugene, OR
Good idea. I released a 2.0.x dev branch with your patch.
- πΊπΈUnited States art4003 New York
Currently in the dev branch there is a space between the '^' and '10'. This is causing an error in Drupal 9.5.
The 'core_version_requirement' constraint (^8 || ^9 || ^ 10) is not a valid value in modules/contrib/simplesamlphp_custom_attributes/simplesamlphp_custom_attributes.info.yml
- πΊπΈUnited States dmundra Eugene, OR
Whoops, thanks for catching that @art4003. Fixed.
Hi
I installed the patch in drupal 9, and the upgrade status showed that drupal/simplesamlphp_custom_attributes is D10 compatible. However, I have to uninstall it during recent D10 upgrade. Patch doesn't seems to be working.- πΊπΈUnited States dmundra Eugene, OR
Hi @drupalgreenhorn did you try both patches? Also instead of the patches try the dev version ( https://www.drupal.org/project/simplesamlphp_custom_attributes/releases/... β ) and see if that works for you.
- πΊπΈUnited States dmundra Eugene, OR
Release 2.0.1 of this module that will support Drupal 10.
- Status changed to Fixed
about 1 year ago 10:51pm 3 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.