Automated Drupal 10 compatibility fixes

Applying #12 and running upgrade status produces theses errors:

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Serial 8.x-1.0-alpha2
Scanned on Fri, 2023-01-27 - 10:47.

2 errors found. 3 warnings found. Avoid some manual work by using drupal-rector
for fixing issues automatically or Upgrade Rector to generate patches.

modules/contrib/serial/src/Plugin/Field/FieldType/SerialItem.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check │ 111 │ Relying on entity queries to check access by default is │
│ manually │ │ deprecated in drupal:9.2.0 and an error will be thrown from │
│ │ │ drupal:10.0.0. Call │
│ │ │ \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with │
│ │ │ TRUE or FALSE to specify whether access should be checked. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/serial/src/SerialSQLStorage.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check │ 197 │ Relying on entity queries to check access by default is │
│ manually │ │ deprecated in drupal:9.2.0 and an error will be thrown from │
│ │ │ drupal:10.0.0. Call │
│ │ │ \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with │
│ │ │ TRUE or FALSE to specify whether access should be checked. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/serial/tests/src/Functional/SerialFieldTest.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 137 │ Call to deprecated method drupalPostForm() of class │
│ rector │ │ Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and │
│ │ │ is removed from drupal:10.0.0. Use $this->submitForm() │
│ │ │ instead. │
│ │ │ │
│ Fix with │ 163 │ Call to deprecated method drupalPostForm() of class │
│ rector │ │ Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and │
│ │ │ is removed from drupal:10.0.0. Use $this->submitForm() │
│ │ │ instead. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/serial/serial.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check │ 0 │ Value of core_version_requirement: ^8 || ^9 is not │
│ manually │ │ compatible with the next major version of Drupal core. See │
│ │ │ https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

Also tested #12, it works for me.

I also made a patch from scratch based on 'update_status'. Patch attached, the main difference is that phpunit tests now also work.

Fixed:

FILE: modules/contrib/serial/tests/src/Functional/SerialFieldTest.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 16   Drupal\Tests\BrowserTestBase::$defaultTheme is required. See
                    https://www.drupal.org/node/3083055, which includes
                    recommendations on which theme to use.
--------------------------------------------------------------------------------
Check manually 137  Call to deprecated method drupalPostForm() of class
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()
                    instead.
--------------------------------------------------------------------------------
Check manually 163  Call to deprecated method drupalPostForm() of class
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()
                    instead.
--------------------------------------------------------------------------------

FILE: modules/contrib/serial/serial.info.yml

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not
                    compatible with the next major version of Drupal core. See
                    https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

Still open as "deprecated in 10.x":

  2x: The theme 'classy' is deprecated. See https://drupal.org/node/3223395#s-classy
    1x in SerialFieldTest::testSerialField from Drupal\Tests\serial\Functional
    1x in SerialFieldTest::testSerialEntityCreation from Drupal\Tests\serial\Functional

I used 'classy' as theme for now to make the tests work again. In https://drupal.org/node/3070687 they suggest to use "stark" as theme but then some more changes are needed in the unit tests.

Thanks @sboden, @reenaraghavan, @maxilein :

I have verified the #14, #12: it is working. I have added patch to resolve the remaining test case warning. Kindly review patch: serial-3298036-15.patch

It is working for the Drupal 10 and Drupal 9.

Patch #15 is getting applied successfully and it is working for me. So moving it to RTBC.

I have not tested the patch but according to the Upgrade Status module, this module is not yet compatible with Drupal 10.

Maybe we need first tag this as "Review" to trigger the "Project Update Bot"

Is this should be tagged as `8.x-1.x-dev` or `8.x-1.x-alpha-2`?

Created MR so that it can be merge directly.
Moving to RTBC.

New release published.

Automatically closed - issue fixed for 2 weeks with no activity.