Account created on 18 August 2022, over 2 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

Patch #5 is working fine for me. The issue was in RTBC rightly. Moving it back to RTBC again.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

kamleshbp โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

kamleshbp โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

Patch #2 created by bot is getting applied successfully. It makes the module D10 compatible. So moving the issue to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

I am adding a patch as well for making the module Drupal 10 compatible. It includes changes in .info.yml file and some deprecation fixes as per upgrade status module. Kindly review the same.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

The patch #2 created by bot is getting applied successfully. It makes the module D10 compatible and also the functionality of the module is working fine as well. Moving the issue to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

I tried applying the patch #2 created by bot. It got applied successfully, but when I tried to import submissions from csv file, I got one TypeError (added the screenshot). I think the issue is with the PHP version (On PHP 8.1 it is giving error, but on the lower versions it was giving a warning only.). Anyway, PHP 8.1 is the minimum requirement for Drupal 10, so this issue has to be fixed. I have added the patch for the same. Kindly review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

I tried the patch on comment #8. But it is giving 2 warnings in upgrade_status scan results (Added the image). So to fix it, I am adding the fixes. Access check is very common so that doesn't require any explanation (I guess). But 2nd warning is that the core/underscore will be removed in Drupal 10. There is a throttle function from underscore.js which is being used in frontend.js file. So I have added the alternative for the same as per this. Kindly review the patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

The patch #2 is getting applied successfully and makes the module D10 compatible. So moving the issue to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

Patch #15 is getting applied successfully and it is working for me. So moving it to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

Patch present in comment #5 ๐Ÿ“Œ Automated Drupal 10 compatibility fixes Fixed is getting applied cleanly and it makes module Drupal 10 compatible. So moving the issue to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

The patch created by bot is getting applied and it is working fine as expected. It makes the module Drupal 10 compatible (checked using Upgrade status module), so moving the issue to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

Patch #1 is working fine for me and it makes the module Drupal 10 compatible. Moving the issue to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

I am adding a patch as well for making the module Drupal 10 compatible. It includes changes in .info.yml file and drupal-check fixes.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

Patch #4 is working fine for me and it makes the module drupal 10 compatible. Moving the issue to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kamleshbp

I tested patch #4 ๐Ÿ“Œ Drupal 10 compatibility issues Fixed . It has one issue, so I have fixed it and added fixes for some drupal-check issues.

Production build 0.71.5 2024