- 🇩🇪Germany Anybody Porta Westfalica
Drupal 10 is out, so this is important!
- 🇩🇪Germany Anybody Porta Westfalica
We're maintainers now and plan to work on it.
We should create a 2.x semver branch for Drupal 10 and further development. Eventually we should merge RTBC'd fixes before doing this.
- Open on Drupal.org →Core: 9.5.5 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇩🇰Denmark ressa Copenhagen
Congrats @Anybody!
Thanks for sharing your plans for a 2.x here, that makes sense. In light of that, instead of creating a new 1.x branch with the changes, I am attaching a patch which allows installing the module in Drupal 10.
It seems to work well, though some HTML is HTML encoded, for example:
Looks good
<div class="description">Your <em class="placeholder"><a href="https://website.lndo.site/admin/config/people/accounts?destination=/admin/reports/prod-check" title="User registration">User registration</a></em> settings are OK for production use.</div>
HTML is escaped
<div class="description">Your <em class="placeholder"><a href="https://website.lndo.site/admin/config/development/logging?destination=/admin/reports/prod-check" title="Error reporting">Error reporting</a></em> settings are set to "Display all messages, plus backtrace information". Are you sure this is what you want and did not mean to use "Display no errors"?</div>
- First commit to issue fork.
- 🇩🇪Germany Grevil
LGTM!
I removed the Drupal 10 compatibility from the "Production Check XML-RPC" submodule, as the depending module https://www.drupal.org/project/xmlrpc → is not Drupal 10 ready (yet), I also created a seperate issue for this: 📌 Make the "prod_check_xmlrpc" submodule Drupal 10 compatible Needs work
"upgrade_status" couldn't find any deprecation notices and the module together with its rest submodule could be installed successfully AND the prod_check page could be opened with no problem.
- @grevil opened merge request.
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: RTBC if it's fine for you!
Just one thing:
\Drupal::service('renderer')
...
Could you add a@todo
comment that this should instead be dependency-injected? - Status changed to RTBC
over 1 year ago 1:03pm 4 May 2023 - Status changed to Fixed
over 1 year ago 1:55pm 4 May 2023 - 🇩🇪Germany Grevil
Damn, I tried to cherry-pick https://git.drupalcode.org/project/prod_check/-/commit/36c4ed09731856973... in 2.x earlier today and got an error, but it seemed like it still got cherry-picked, apparently, I was on the wrong branch-
Oh well, don't mind the scope creep, this MR also contains the changes from https://git.drupalcode.org/project/prod_check/-/commit/36c4ed09731856973..., as I already cherry-picked another issue afterwards...
Automatically closed - issue fixed for 2 weeks with no activity.