- 🇧🇪Belgium JeroenT 🇧🇪
When applying the patch in #4 and running drupal-check I get the following errors:
================================================================================ Paragraphs Asymmetric Translation Widgets, 8.x-1.1 Scanned on za, 01/21/2023 - 22:52 FILE: web/modules/contrib/paragraphs_asymmetric_translation_widgets/tests/src/Function al/ParagraphsAsymmetricTranslationTest.php STATUS LINE MESSAGE -------------------------------------------------------------------------------- Check manually 15 Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use. -------------------------------------------------------------------------------- FILE: web/modules/contrib/paragraphs_asymmetric_translation_widgets/paragraphs_asymmet ric_translation_widgets.info.yml STATUS LINE MESSAGE -------------------------------------------------------------------------------- Check manually 0 Value of core_version_requirement: ^8 || ^9 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687. --------------------------------------------------------------------------------
- Status changed to Needs work
almost 2 years ago 9:54pm 21 January 2023 - Status changed to Needs review
almost 2 years ago 9:59pm 21 January 2023 - 🇧🇪Belgium JeroenT 🇧🇪
This patch should fix all found issues:
Paragraphs Asymmetric Translation Widgets, 8.x-1.1 Scanned on za, 01/21/2023 - 22:54 No known issues found.
- First commit to issue fork.
- 🇦🇺Australia realityloop
I added the patch to an issue branch, as well as updating the composer.json file so that I could use it in composer without the need for the patch, allowing me to upgrade to Drupal 10.
The following (or similar) is required in your projects composer.json:
"repositories": { "drupal": { "type": "composer", "url": "https://packages.drupal.org/8", "exclude": [ "drupal/paragraphs_asymmetric_translation_widgets" ] }, "drupal/paragraphs_asymmetric_translation_widgets": { "type": "git", "url": "https://git.drupalcode.org/issue/paragraphs_asymmetric_translation_widgets-3297814.git" } },
Then add the module using:
composer require drupal/paragraphs_asymmetric_translation_widgets:dev-3297814-automated-drupal-10
I hope this is helpful to others.
- First commit to issue fork.
- @sleitner opened merge request.
- Status changed to RTBC
over 1 year ago 7:51am 12 March 2023 - 🇪🇸Spain himanshu5050 Spain
Entity queries must explicitly set for access check in Drupal 10. Failing at paragraphs_asymmetric_translation_widgets_entity_translation_delete
Drupal\Core\Entity\EntityStorageException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck().
- Status changed to Needs work
over 1 year ago 5:31am 14 March 2023 - Status changed to Needs review
over 1 year ago 5:52am 14 March 2023 The last submitted patch, 23: 3297814-23.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to RTBC
over 1 year ago 6:46am 22 March 2023 - 🇫🇮Finland merilainen
Looks good to me, after patching Upgrade status saysNo problems found.
I will mark this as RTBC as the changes are simple replacements which Drupal Rector could do. -
Rajab Natshah →
committed ac4dac16 on 8.x-1.x authored by
sleitner →
Issue #3297814: Automated Drupal 10 compatibility fixes
-
Rajab Natshah →
committed ac4dac16 on 8.x-1.x authored by
sleitner →
- Status changed to Fixed
over 1 year ago 8:57am 13 April 2023 - 🇯🇴Jordan Rajab Natshah Jordan
Release note
- Issue #3297814 → by JeroenT → , Project Update Bot → , realityloop → , Himanshu5050 → , sleitner → , Rajab Natshah → , mErilainen → : Automated Drupal 10 compatibility fixes
- 🇯🇴Jordan Rajab Natshah Jordan
Thank you everyone.
✅ Released Paragraphs asymmetric translation widgets 8.x-1.2 →
- Status changed to Fixed
over 1 year ago 9:44am 27 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- 🇪🇸Spain oriol masjuan
Hi everybody,
I am still having the same issue with Drupal 10 about the accessCheck error. When deleting translation content I get this error:
Drupal\Core\Entity\EntityStorageException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck(). in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 815 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
Drupal\Core\Entity\Query\Sql\Query->execute() (Line: 112)
paragraphs_asymmetric_translation_widgets_entity_translation_delete(Object)
call_user_func_array(Object, Array) (Line: 409)
Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object, 'paragraphs_asymmetric_translation_widgets') (Line: 388)...It seems that Paragraphs asymmetric translation widgets 8.x-1.2 and 8.x-dev haven't got the Patch #23.
Adding the line ->accessCheck(TRUE) the problem doesn't appear anymore.
I created a patch to apply to version 8.x-1.2 to solve temporally the problem. This patch only adds line ->accessCheck(TRUE)
- 🇯🇴Jordan Rajab Natshah Jordan
Thanks, oriol for reporting
Please, file a new issue for this bug.
To be fixed for sure.