- First commit to issue fork.
- π¬π§United Kingdom jonnyhocks
I've applied the patch in #11 to the issue forked branch.
- π³πΏNew Zealand xurizaemon Εtepoti, Aotearoa π
Noting that the patch here looked at first (to me) like it had unrelated changes, but I think these are #3028612: Deprecate menu_ui_get_menus() and replace all of its usages β -
menu_ui_get_menus()
is now deprecated, and we load menu entities directly. - π§πͺBelgium ludo.r Brussels
@xurizaemon, indeed
menu_ui_get_menus()
doesn't exist anymore in D10. - Status changed to Needs review
almost 2 years ago 6:03pm 2 February 2023 - π³πΏNew Zealand xurizaemon Εtepoti, Aotearoa π
Concur, updated patch attached. Would be happy to merge this but will fire tests on it first.
The last submitted patch, 17: menu_breadcrumb-3297634-17.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.The last submitted patch, 19: menu_breadcrumb-3297634-18.patch, failed testing. View results β
- Status changed to Needs work
almost 2 years ago 2:39pm 3 February 2023 - π¦π²Armenia le72 Yerevan π¦π²
This is the one of few modules which prevent our upgraded to D10!
Please add a new version. - π³πΏNew Zealand xurizaemon Εtepoti, Aotearoa π
Tests are failing here because of π Add automated test coverage Needs review , not because of the proposed changes.
I will merge this as-is based on RTBC from others and some limited local testing, then make a beta release of next 8.x-1.n which can be used for D10 sites in the interim.
Meanwhile we can progress the other issues in π Release coordination issue for Menu Breadcrumb 2.0.0 Active which will make for a tidier D10 release in 2.0.0.
-
xurizaemon β
committed e81c69d8 on 8.x-1.x
Issue #3297634 by reenaraghavan, jonnyhocks, Project Update Bot, Ludo.R...
-
xurizaemon β
committed e81c69d8 on 8.x-1.x
-
xurizaemon β
committed e81c69d8 on 2.0.x
Issue #3297634 by reenaraghavan, jonnyhocks, Project Update Bot, Ludo.R...
-
xurizaemon β
committed e81c69d8 on 2.0.x
- Status changed to Fixed
almost 2 years ago 9:13pm 6 February 2023 - π³πΏNew Zealand xurizaemon Εtepoti, Aotearoa π
Release created as 2.0.0-alpha0 as I think doing it as an alpha of 8.x-1.17 would just have created additional work in future.
Grateful if folks will confirm it's working OK for them!
Thanks all.
- π«π·France zenimagine
Hi, I have a site with drupal 10, which version of this module should I install, on my site in production? Is it stable? THANKS
- π³πΏNew Zealand xurizaemon Εtepoti, Aotearoa π
Please use 2.0.x series for Drupal 10 - try
composer require 'drupal/menu_breadcrumb:^2.0@alpha'
- π«π·France zenimagine
it is written alpha-0 does this risk breaking the site or the module in the future ?
- π³πΏNew Zealand xurizaemon Εtepoti, Aotearoa π
Nobody plans to break things, but the alpha0 indicates that the module is available for testing and feedback.
You can contribute to this!
As far as risks go, you have to make your own best evaluation.
The clearest answer I can offer is this view of the actual changes:
- From 8.x-1.16 to 2.0.x - https://git.drupalcode.org/project/menu_breadcrumb/-/compare/8.x-1.16......
- From 8.x-1.16 to 2.0.0-alpha0 - https://git.drupalcode.org/project/menu_breadcrumb/-/compare/8.x-1.16...... - π«π·France zenimagine
Ok thanks, I just installed it and it works on Drupal 10
Automatically closed - issue fixed for 2 weeks with no activity.