- ๐ฎ๐ณIndia Vishal Choudhary Dharmshala
I have created a patch to be Compatible with this module with Drupal 10 and tested it, and it's working fine.
Step to Port this module
1. Check the Deprecated code with the help of Drupal check like command
vendor/mglaman/drupal-check/drupal-check modules/contrib/extra_css_js/ - First commit to issue fork.
- ๐ฎ๐ณIndia dineshkumarbollu
Hi
The patch applied failed because In D10 Core : 8.x is deprecated.
git apply -v drupal.org_files_issues_2023-03-16_Patch_File_PortD10.patch
Checking patch extra_css_js.info.yml...
error: while searching for:
type: module
description: Provide Extra Css and JS
core: 8.x
core_version_requirements: ^8 || ^9
configure: extra_css_js.admin_settingserror: patch failed: extra_css_js.info.yml:2
error: extra_css_js.info.yml: patch does not apply
Checking patch extra_css_js.module...
error: while searching for:
$css_suffix = \Drupal::state()->get('extra_css_suffix') ?: NULL;
$themes = \Drupal::config('extra_css_js.settings')->get('extra_css_js_themes');
$active_theme = \Drupal::service('theme.manager')->getActiveTheme()->getName();
if (empty($themes) || (!empty($themes) && in_array($active_theme, $themes))) {
if ($css_suffix) {
$cssfile = EXTRA_CSS_PATH . '/extra_css_js_' . $css_suffix . '.css';
}error: patch failed: extra_css_js.module:41
error: extra_css_js.module: patch does not appl - @dineshkumarbollu opened merge request.
- Status changed to RTBC
over 1 year ago 10:43am 6 July 2023 - ๐ฎ๐ณIndia dineshkumarbollu
Hi
I created MR for this Issue and also attaching D10 report .
Thanks
- ๐บ๐ธUnited States dasginganinja Bethlehem, PA
Will this module be seeing an update into Drupal 10? I surely would like to continue usage of this module but will find another way if needed.
- Assigned to Jeya sundhar
- Status changed to Needs work
about 1 year ago 7:59am 8 November 2023 - ๐ฎ๐ณIndia Jeya sundhar Coimbatore
Hi all,
I reviewed this branch(3297166-D10-compatible).
CSS & JS Directory not created - Status changed to Needs review
about 1 year ago 5:53am 9 November 2023 - ๐ฎ๐ฉIndonesia winnie80
hai there,
it has been 4 months
is there any plan to make an official d10 compatible version of this module? - Issue was unassigned.
- ๐ซ๐ทFrance slayne40
Warning: Undefined array key "license" in Drupal\Core\Asset\JsCollectionOptimizerLazy->optimizeGroup() (line 169 of core/lib/Drupal/Core/Asset/JsCollectionOptimizerLazy.php).