Automated Drupal 10 compatibility fixes

Created on 18 July 2022, over 2 years ago
Updated 13 March 2024, 9 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects โ†’

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot โ†’ official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot โ†’ .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot โ†’ , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue โ†’ . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue โ†’ using the component โ€œBot: Drupal Rectorโ€.

๐Ÿ“Œ Task
Status

Needs review

Version

2.2

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Vishal Choudhary Dharmshala

    I have created a patch to be Compatible with this module with Drupal 10 and tested it, and it's working fine.
    Step to Port this module
    1. Check the Deprecated code with the help of Drupal check like command
    vendor/mglaman/drupal-check/drupal-check modules/contrib/extra_css_js/

  • First commit to issue fork.
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia dineshkumarbollu

    Hi

    The patch applied failed because In D10 Core : 8.x is deprecated.

    git apply -v drupal.org_files_issues_2023-03-16_Patch_File_PortD10.patch
    Checking patch extra_css_js.info.yml...
    error: while searching for:
    type: module
    description: Provide Extra Css and JS
    core: 8.x
    core_version_requirements: ^8 || ^9
    configure: extra_css_js.admin_settings

    error: patch failed: extra_css_js.info.yml:2
    error: extra_css_js.info.yml: patch does not apply
    Checking patch extra_css_js.module...
    error: while searching for:
    $css_suffix = \Drupal::state()->get('extra_css_suffix') ?: NULL;
    $themes = \Drupal::config('extra_css_js.settings')->get('extra_css_js_themes');
    $active_theme = \Drupal::service('theme.manager')->getActiveTheme()->getName();
    if (empty($themes) || (!empty($themes) && in_array($active_theme, $themes))) {
    if ($css_suffix) {
    $cssfile = EXTRA_CSS_PATH . '/extra_css_js_' . $css_suffix . '.css';
    }

    error: patch failed: extra_css_js.module:41
    error: extra_css_js.module: patch does not appl

  • @dineshkumarbollu opened merge request.
  • Status changed to RTBC over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia dineshkumarbollu

    Hi

    I created MR for this Issue and also attaching D10 report .

    Thanks

  • ๐Ÿ‡บ๐Ÿ‡ฆUkraine rznasa

    Can we move the issue forward?

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dasginganinja Bethlehem, PA

    Will this module be seeing an update into Drupal 10? I surely would like to continue usage of this module but will find another way if needed.

  • Assigned to Jeya sundhar
  • Status changed to Needs work about 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Jeya sundhar Coimbatore

    Hi all,
    I reviewed this branch(3297166-D10-compatible).
    CSS & JS Directory not created

  • Status changed to Needs review about 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Jeya sundhar Coimbatore
  • ๐Ÿ‡ฎ๐Ÿ‡ฉIndonesia winnie80

    hai there,
    it has been 4 months
    is there any plan to make an official d10 compatible version of this module?

  • ๐Ÿ‡ซ๐Ÿ‡ทFrance slayne40

    Merge #3 and #10

  • Issue was unassigned.
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Jeya sundhar Coimbatore
  • ๐Ÿ‡ซ๐Ÿ‡ทFrance slayne40

    Warning: Undefined array key "license" in Drupal\Core\Asset\JsCollectionOptimizerLazy->optimizeGroup() (line 169 of core/lib/Drupal/Core/Asset/JsCollectionOptimizerLazy.php).

  • ๐Ÿ‡ซ๐Ÿ‡ทFrance slayne40
  • ๐Ÿ‡ซ๐Ÿ‡ทFrance slayne40

    Sorry invalid patch file #15 and #16.

Production build 0.71.5 2024