- Issue created by @project update bot
This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module โ , even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.yml
file for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot โ to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #139This patch was created using these packages:
- mglaman/phpstan-drupal: 1.1.24
- palantirnet/drupal-rector: 0.13.0
- ๐ฆ๐บAustralia dpi Perth, Australia
Drupal 10 support will be addressed in the near future. It is not currently a priority.
- heddn Nicaragua
In addition to what the bot was able to fix, there's also:
- web/modules/contrib/date_recur_modular/templates/date-recur-modular-sierra-widget.html.twig 0 The spaceless tag in "modules/contrib/date_recur_modular/templates/date-recur-modular-sierra-widget.html.twig" at line 3 is deprecated since Twig 2.7, use the "spaceless" filter with the "apply" tag instead. See https://drupal.org/node/3071078..
- web/modules/contrib/date_recur_modular/date_recur_modular.libraries.yml 0 The 'date_recur_modular_sierra_widget' library is depending on a deprecated library. The core/jquery.once asset library is deprecated in Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the core/once library instead. See https://www.drupal.org/node/3158256 โ
Since drupal 10 is now released, this seems a bit more important now.
- heddn Nicaragua
This should do the trick. I bumped the minimum version of drupal core to 9.2 given we have to support the new once js library. Which was only made available in that version.
- ๐ฎ๐ณIndia yashingole
I have reviewed and checked Patch #5 this works for drupal 9.5 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5 and the Permission page along with the Field added page on 10 have been attached for reference: - First commit to issue fork.
- First commit to issue fork.
- @ekes opened merge request.
- ๐ณ๐ฑNetherlands ekes
Issue fork date_recur_modular-3296930 3.x branch contains:-
- Applied patch by @heddn for Drupal 10 support #3296930 Stephen Cox Which has the automated updates, plus work that was required to fix the javascript in the sierra widget;
- ekes's avatar Issue #3296930: Fix tests for 10.x ekes Updates the tests to use 10.x compatible stark in place of classy, requiring one selector change;
- Issue #3301519: The specified #ajax callback is empty or not callable Alex Sharkov Required to make Sierra work with PHP 8+, a Drupal 10 requirement.
Also attaching patch version of the branch to this.
- Status changed to RTBC
almost 2 years ago 1:39pm 29 January 2023 - ๐ณ๐ฑNetherlands ifrik
I've tested this for the form widgets "Modular: Sierra" (with "Default interpreter"), "Modular: Oscar" and "Modular: Alpha" with the different options in each widget enabled and disabled.
They all work as expected. Dates and their recurrence can be changed and changing the widget also works fine.
- Status changed to Fixed
almost 2 years ago 4:42am 13 February 2023 - ๐ฆ๐บAustralia dpi Perth, Australia
A handful of commits can be found in 3.1.0-rc1.
Note minor changes for PHP + core + dependent constraints: PHP 8.0, Core >=9.5, Recurring Date Field 3.2.
Thanks everyone
Automatically closed - issue fixed for 2 weeks with no activity.