- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 3:26pm 12 July 2023 - First commit to issue fork.
Hi @fabianderijk,
Just wondering if you still want to merge this PR as we are actively use it and would be nice to see it as a part of your module.- π³π±Netherlands fabianderijk Alphen aan den Rijn
Hi @vnech, yes i would like to have this added to the module. I just haven't had a lot of time to check this.
In the meantime, the 5.0.x branch has been created, and I think this should be added there as well as all new features will be added there. I've c opied all changes from the MR to a MR for the 5.0.x branch. Everything seems to be working there. I've tested it, and I can login using multiple Azure apps.
Can someone check as well: https://git.drupalcode.org/project/o365/-/merge_requests/33
- Merge request !34Issue #3295745: Make it possible to use multiple Office 365 connectors (5.x) β (Open) created by codebymikey
- π³π±Netherlands fabianderijk Alphen aan den Rijn
I will do a check on this code today.
When this works we will have to come up with a strategy on how to release this because this is a major change and may (better yet, will) break working sites. So we probably need to make a 6.0.x branch first before so we can merge this MR into that branch, write documentation on how to upgrade, etcetera.
- Status changed to RTBC
12 months ago 12:43pm 27 November 2023 - π³π±Netherlands fabianderijk Alphen aan den Rijn
I've reviewed everything on a working intranet we use the module on. Everything is working when using the code in de MR.
I will create a 6.0.x branch to merge this into and start writing documentation on how to upgrade.
Great work everyone!
Attached a static patch of the current MR supporting the latest 5.0.4 version.
Attached a version which uses a post update hook to avoid collision with the existing π logout Fixed update hook.
codebymikey β changed the visibility of the branch feature/3295745-multiple-connectors-5.0.4 to hidden.
codebymikey β changed the visibility of the branch 3295745 to hidden.