All the fields border color changes to red when we enter an invalid URL

Open on Drupal.org →

Created on 8 July 2022, almost 2 years ago

Updated 27 March 2023, over 1 year ago

Problem/Motivation

When we enter an invalid URL, all the fields border color change to red

Steps to reproduce

Set a Link type field to use widget "Link (with Attributes)".

Go to add/edit page for the respective content type (or any entity type) and set a wrong URL respective to the format (htts://www.google.com)

Proposed resolution

Change the validation system, put in error only the url part and not all the fields of the link.

🐛 Bug report

Status

Needs work

Version

10.1 ✨

Component

Last updated about 7 hours ago

Maintained by
🇧🇷Brazil @Mac_Weber

Created by

🇲🇦Morocco jamaoui

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Needs screenshots
The change alters the user interface, so before and after screenshots should be added to document the UI change. Make sure to capture the relevant region only. Use a tool such as Aviary on Windows or Skitch on Mac OS X.

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇧🇩Bangladesh eashika
Comment over 1 year ago →
🇧🇩Bangladesh eashika
@enaznin opened merge request.
Status changed to Needs review over 1 year ago11:44am 26 February 2023
Comment over 1 year ago →
🇧🇩Bangladesh eashika
Status changed to Needs work over 1 year ago5:18pm 26 February 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

As a bug this will need a test case.

Since it's changing the UI before/after screenshots should be added to the issue summary after the final patch.
Comment over 1 year ago →
🇧🇩Bangladesh eashika
Added after screenshot
First commit to issue fork.
Comment over 1 year ago →
🇧🇷Brazil carolpettirossi Campinas - SP
I'm trying to review this issue and help with tests. However, the Issue summary is not complete.
I couldn't find the widget "Link (with Attributes)" in the Manage Form Display tab.

@enaznin, can you please update the Issue Summary adding more details about field type, field widget, and modules that must be enabled?

Thanks :)

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024