Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org ā†’
Created on 29 June 2022, about 2 years ago
Updated 30 May 2024, about 1 month ago

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\domprocessor\src\DomProcessor\ChainedDomProcessorInterface.php
----------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
5 | WARNING | [x] Unused use statement
7 | ERROR | [x] Missing interface doc comment
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\domprocessor\src\DomProcessor\DomProcessorEventSubscriber.php
---------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
12 | ERROR | [x] Missing class doc comment
14 | ERROR | [ ] Missing member variable doc comment
16 | ERROR | [ ] Missing member variable doc comment
18 | ERROR | [x] Missing function doc comment
23 | ERROR | [x] Missing function doc comment
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\domprocessor\src\DomProcessor\DomProcessorInterface.php
---------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
7 | ERROR | [x] Missing interface doc comment
9 | ERROR | [x] Missing function doc comment
11 | ERROR | [x] Missing function doc comment
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\domprocessor\src\DomProcessor\DomProcessorManager.php
-------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
7 | ERROR | [x] Missing class doc comment
26 | ERROR | [ ] Missing short description in doc comment
38 | ERROR | [ ] Missing short description in doc comment
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\domprocessor\src\UrlProcessor\ChainedUrlProcessorInterface.php
----------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
5 | WARNING | [x] Unused use statement
7 | ERROR | [x] Missing interface doc comment
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\domprocessor\src\UrlProcessor\DomProcessorForUrlProcessorManager.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
8 | ERROR | [x] Missing class doc comment
10 | ERROR | [ ] Missing member variable doc comment
12 | ERROR | [x] Missing function doc comment
16 | ERROR | [x] Missing function doc comment
20 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\domprocessor\src\UrlProcessor\UrlProcessorInterface.php
---------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
8 | ERROR | [x] Missing interface doc comment
10 | ERROR | [x] Missing function doc comment
12 | ERROR | [x] Missing function doc comment
14 | ERROR | [x] Missing function doc comment
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\domprocessor\src\UrlProcessor\UrlProcessorManager.php
-------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
5 | WARNING | [x] Unused use statement
6 | WARNING | [x] Unused use statement
10 | ERROR | [x] Missing class doc comment
29 | ERROR | [x] Missing function doc comment
38 | ERROR | [x] Missing function doc comment
44 | ERROR | [x] Missing function doc comment
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------

šŸ“Œ Task
Status

Needs work

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India Harsh panchal

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 1 year ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
    +   * @var \Symfony\Component\HttpKernel\Event\domProcessorManager
+   *   The event to process.

    After the @var line there must not be any description, which is already given before that line.

    +  /**
+   * Applies.
+   */
   public function applies(HtmlResponse $response): bool;

    That description is not sufficient and it repeats the method name.
    The parameters nor the return value is described.

  • Status changed to Needs review 6 months ago
  • Comment 6 months ago ā†’
    šŸ‡®šŸ‡³India zkhan.aamir

    Addressed the changes mentioned in comment #4.
    Please review.

  • Issue was unassigned.
  • Comment 6 months ago ā†’
    šŸ‡®šŸ‡³India zkhan.aamir
  • Status changed to Needs work about 1 month ago
  • Comment about 1 month ago ā†’
    a.aaronjake

    Hi @zkhan.aamir,

    I applied the patch successfully, one error still unfixed.

    domprocessor git:(1.x) curl https://www.drupal.org/files/issues/2023-12-19/phpcs-drupal-coding-standard-3293265-5.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7614  100  7614    0     0  15048      0 --:--:-- --:--:-- --:--:-- 15289
patching file src/DomProcessor/ChainedDomProcessorInterface.php
patching file src/DomProcessor/DomProcessorEventSubscriber.php
patching file src/DomProcessor/DomProcessorInterface.php
patching file src/DomProcessor/DomProcessorManager.php
patching file src/UrlProcessor/ChainedUrlProcessorInterface.php
patching file src/UrlProcessor/DomProcessorForUrlProcessorManager.php
patching file src/UrlProcessor/UrlProcessorInterface.php
patching file src/UrlProcessor/UrlProcessorManager.php
āžœ  domprocessor git:(1.x) āœ— cd ..
āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig domprocessor

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/domprocessor/src/DomProcessor/DomProcessorInterface.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
 15 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------

Time: 169ms; Memory: 10MB

    Kindly check

    Thanks,
    Jake

  • Merge request !2Issue #3293265: Fix the issues reported by phpcs ā†’ (Open) created by apaderno
  • Pipeline finished with Failed
    about 1 month ago
    Total: 29s
    #185941
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024