- 🇮🇳India arunkumark Coimbatore
I tested the patch working as expected to remove the unused variable
$config
.Before applying patch:
After applying patch:
But there are a few other warnings. It would be great we are resolving all the warning errors.
Warnings are,
FILE: /var/www/html/web/modules/custom/menu_item_role_access/src/Form/ConfigForm.php ----------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 10 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ----------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/menu_item_role_access/src/MenuItemRoleAccessLinkTreeManipulator.php ----------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------- 79 | WARNING | MenuLinkContent::load calls should be avoided in classes, use dependency injection instead 91 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead -----------------------------------------------------------------------------------------------------------
- Status changed to Closed: duplicate
about 2 years ago 7:27am 21 March 2023 - 🇮🇳India hardikpandya
This would be covered as part of https://www.drupal.org/project/menu_item_role_access/issues/3293109 🐛 Fix the issues reported by phpcs Needs review where more work for fixing all phpcs issues is being done. Closing this!