Contrib.social

The comments heading should not be displayed on node pages in core themes including Olivero when no comments have been posted

Open on Drupal.org →
Created on 20 June 2022, about 2 years ago
Updated 9 February 2023, over 1 year ago

Problem/Motivation

When you have a content type that allows commenting, nodes with no comments posted show the “Comments” heading.

In my opinion, this heading should only be present when there are comments, as this is more logical and provides for a cleaner page layout.

Steps to reproduce

1. Have a content type configured to allow comments.
2. Have Olivero as the default theme (other core themes also exhibit this same behaviour).
3. Navigate to a node from the content type which has no comments.
4. Compare this to a node that does have comments.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Needs work

Version

10.1 ✨

Component
Olivero  →

Last updated about 8 hours ago

Created by

🇬🇧United Kingdom Janner

Live updates comments and jobs are added and updated live.
  • Needs usability review

    Used to alert the usability topic maintainer(s) that an issue significantly affects (or has the potential to affect) the usability of Drupal, and their signoff is needed. When adding this tag, make it easy to review the issue. Make sure the issue summary describes the problem and the proposed solution. Screenshots usually help a lot! To get sign-off on issues with the "Needs usability review" tag, post about them in the #ux channel on Drupal Slack, and/or attend a UX meeting to demo the patch and get direct feedback from designers/UX folks/product management on next steps. If an issue represents a significant new feature, UI change, or change to the general "user experience" of Drupal, use Needs product manager review instead. See the scope of responsibilities for product managers.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    As this is a bug it will need a test showing the issue.

    Also was previously tagged for issue summary update for proposed solution and screenshots which still needs to happen.

    SInce this is changing how the theme behaves will it need a change record?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024