- π©πͺGermany Anybody Porta Westfalica
Thanks @geek-merlin, I never said anyone is lazy here :) Just a ping. Good to know, it's on the radar.
I'll put this one on our list, let's see who's first. Thanks! - First commit to issue fork.
- Status changed to Needs review
about 2 years ago 11:05am 30 January 2023 - π©πͺGermany Grevil
LGTM! I checked for remaining deprecation notices, using the upgrade_status module and PHPStan.
Adjusted the info file and added a fallback return for "evaluate()".
- Status changed to RTBC
about 2 years ago 11:09am 30 January 2023 - π©πͺGermany Grevil
The module installs successfully, and the tests run under Drupal 10! RTBC!
- @grevil opened merge request.
- π©πͺGermany Anybody Porta Westfalica
Thanks @Grevil for creating the MR!
Re-confirming RTBC and readyness for a Drupal 10 release :) - Status changed to Needs work
about 2 years ago 9:29pm 18 February 2023 - π©πͺGermany geek-merlin Freiburg, Germany
Not quite there. Die return Zeile berΓΌcksichtigt negate nicht, und ist eh unrelated. Never mix in unrelated...
- Status changed to Needs review
about 2 years ago 1:56pm 19 February 2023 - π©πͺGermany Anybody Porta Westfalica
Thx @geek-merlin, indeed!
Should I create a separate issue "evaluate() should always return a boolean result" or sth. like that?
- π©πͺGermany Anybody Porta Westfalica
Should I create a separate issue "evaluate() should always return a boolean result" or sth. like that?
Just did that, so we can discuss it over there: π evaluate() should always return a boolean Needs review
So the follow-ups are:
π Fix Coding Standards Needs work
π evaluate() should always return a boolean Needs review - Status changed to RTBC
about 2 years ago 4:34pm 21 February 2023 -
geek-merlin β
committed e9102ec6 on 8.x-1.x authored by
Grevil β
Issue #3290292 by Grevil, Anybody, Project Update Bot, geek-merlin:...
-
geek-merlin β
committed e9102ec6 on 8.x-1.x authored by
Grevil β
- Status changed to Fixed
about 2 years ago 4:38pm 21 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.