- Issue created by @Anybody
- @anybody opened merge request.
- Status changed to Needs review
about 2 years ago 2:05pm 19 February 2023 - 🇩🇪Germany Anybody Porta Westfalica
Tried to save us from code duplications. If you like a more simple approach, we can also just add a return value:
return $this->isNegated() ? FALSE : TRUE;
at the end instead, of course. And keep the existing logic.
Result should be the same.
- 🇩🇪Germany geek-merlin Freiburg, Germany
Yay, code-wise this looks good and clean.
Code looks good, but it's not tested, and i trust no human brain, not even mine, to grok code execution.
We have an install and uninstall test, but no unit test for this simple piece of functionality.
Can you add a test (unit test is enough) or at least test manually? - 🇩🇪Germany Anybody Porta Westfalica
@geek-merlin totally understand and agree ;) The main reason for this issue was to not forget this. I think it's really minor, but will put this on our list for at least a manual test. But don't expect it too soon. :)
- 🇩🇪Germany geek-merlin Freiburg, Germany
Good, so we'll tacke this further then.