Automated Drupal 10 compatibility fixes

I have applied patch of MR !1 of Shivam_tiwari. Still said patch using the theme_styleswitcher_admin_styles_table & theme_styleswitcher_admin_styles_table theme function. These functions are deprecated. Remove these functions.

Updated patch for Drupal 10 compatibility

Updated patch for Drupal 10 compatibility

Updated patch with all fixes.

Patch for 8.x-2.0 version

Thank you folks for your work on this issue!

Tests are failing, so changing status to NW. Going to review and test everything myself.

pingwin4eg → closed merge request !1

Closed MR, because it was not full.

1. +++ b/js/styleswitcher.js
   @@ -56,14 +56,16 @@
   -    // Update the cookie first.
   -    Drupal.styleSwitcher.cookie(style.name);
   +    if (style) {
   +      // Update the cookie first.
   +      Drupal.styleSwitcher.cookie(style.name);
    
   -    // Now switch the stylesheet. Path is absolute URL with scheme.
   -    $('#styleswitcher-css').attr('href', style.path);
   +      // Now switch the stylesheet. Path is absolute URL with scheme.
   +      $('#styleswitcher-css').attr('href', style.path);
    
   -    // Cosmetic changes.
   -    Drupal.styleSwitcher.switchActiveLink(style.name);
   +      // Cosmetic changes.
   +      Drupal.styleSwitcher.switchActiveLink(style.name);
   +    }
      };
   

   Is this necessary?

2. +++ b/styleswitcher.libraries.yml
   @@ -6,7 +6,7 @@ styleswitcher:
   -    - core/jquery.once
   +    - core/once
   

   jQuery is still used in styleswitcher.js.

Interdiffs would save reviewers' time, by the way.

if condition is added to resolve "Uncaught TypeError: Cannot read properties of undefined (reading 'name')"

Does it happen only in D10?

No. The same error is showing for D8 and D9 as well.

Then it's a separate issue (and requires steps/explanation how it happens). This one is for compatibility fixes.

Manual testing showed a bug - "dynamic" style switching doesn't work, you can see a style applied only after a page refresh or after opening another page. This misbehavior happens only in Drupal 10 on a real site, but not under the test (which is weird). So basically that is not an incompatibility with D10.

I'm going to commit the changes in the patch, and start a new issue for the described bug.

Opened 🐛 Fix dynamic style switching in D10 Active for the described bug.

Thanks again everyone who worked on compatibility fixes.

Automatically closed - issue fixed for 2 weeks with no activity.