- @vladimiraus opened merge request.
- 🇧🇷Brazil renatog Campinas
Worked fine but I think composer.json can be improved to follow the standard of D.O on this documentation: https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file →
- 🇧🇷Brazil renatog Campinas
Patch with that improvement of #7 in the composer.json
P.s. I tried to update the MR but even with push access I weren't able to do
- 🇧🇷Brazil renatog Campinas
Done. I updated the MR with the suggestion of #7. Is ready to be merged: https://git.drupalcode.org/project/scrollup/-/merge_requests/3#3957b91a0...
Thank you so much
- Status changed to RTBC
almost 2 years ago 6:10am 27 January 2023 - 🇧🇷Brazil renatog Campinas
@VladimirAus since it was validated and is working fine, do you think we can go ahead merging the MR?
- Status changed to Needs work
about 1 year ago 1:12pm 16 November 2023 - Status changed to Needs review
about 1 year ago 2:12pm 16 November 2023 - 🇮🇳India mauryarahul11 Mumbai, India
I have Updated MR to fix issue - jQuery.Deferred exception: Selector must not be empty 🐛 jQuery.Deferred exception: Selector must not be empty Active
- Status changed to RTBC
about 1 year ago 12:10pm 24 November 2023 - 🇦🇺Australia VladimirAus Brisbane, Australia
Thank you everyone! Commited! 🧁
-
VladimirAus →
committed c900e6d1 on 3.0.x authored by
renatog →
Issue #3289498 by VladimirAus, renatog, Project Update Bot,...
-
VladimirAus →
committed c900e6d1 on 3.0.x authored by
renatog →
- Status changed to Fixed
about 1 year ago 12:24pm 24 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.