To resolve this issue, I have updated existing MR here - https://git.drupalcode.org/project/scrollup/-/merge_requests/3
After merging of MR, this issue can be fixed.
I have Updated MR to fix issue - jQuery.Deferred exception: Selector must not be empty 🐛 jQuery.Deferred exception: Selector must not be empty Active
This issue caused due to improper handling of once code in scrollup_top.js file in a merge request raised in issue
Automated Drupal 10 compatibility fixes
📌
Automated Drupal 10 compatibility fixes
RTBC
Ideally, we should not use that patch as merge request (MR) for D10 Compatibility issue 📌 Automated Drupal 10 compatibility fixes RTBC is still in review and not merged.
But still anyone wants to go for that patch then refer fix I have given here -https://git.drupalcode.org/project/scrollup/-/merge_requests/3#note_231985
mauryarahul11 → made their first commit to this issue’s fork.
Hi @mitthukumawat,
Do we really need this custom work for website feedback export? We can simply use Views data export → module to download website feedback data in csv format.
I feel this approach will be ideal where user can even configure website_feedback entity fields as per their need (as there given a provision to add new new fields in website_feedback entity).
The patch you have given will fail in case user adds new fields to website_feedback entity. With views data export contrib module we can make it dynamic on the fly. The concern @andrei.vesterli raised about batch export can easily be achieved with this.
Hey @shiv_yadav,
Please run codesniffer with DrupalPractice also.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
Hey @shiv_yadav, Looking at your patch I can not see fix related \Drupal and t() calls should be avoided in classes issues. Can you check that again??
mauryarahul11 → created an issue.