Automated Drupal 10 compatibility fixes

Created on 16 June 2022, over 2 years ago
Updated 9 June 2023, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • @mattjones86 opened merge request.
  • 🇺🇸United States mark_fullmer Tucson

    Note: since this module does not have any additional dependencies or requirements, the addition of the `composer.json` file in the MR above is techincally superfluous, if innocuous.

    From https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file :

    If a module does not have any dependencies, or the dependencies are solely other Drupal modules, then a composer.json is not required. However, having a composer.json does not have a negative impact either.

    So, in this case, the patch in #4 is still sufficient.

  • Status changed to RTBC almost 2 years ago
  • 🇩🇪Germany sleitner

    Both #4 and #7 are working fine. The maintainers should decide if they want a composer.json or not.

  • 🇬🇧United Kingdom mattjones86 🇬🇧 GMT+0

    composer.json is actually important if you wish to include a merge request with composer directly:

    {
    ...
        "repositories": {
            "node_view_permissions": {
                "type": "vcs",
                "url": "https://git.drupalcode.org/issue/node_view_permissions-3288795"
            },
       }
    ...
        "require": {
            "drupal/node_view_permissions": "dev-3288795-automated-drupal-10"
        }
    }
    

    Without it, such installation is impossible.

  • 🇮🇳India sarathkp

    Patch #4 is failing for me in Drupal 10.0.7
    Giving the below error:

    ------ ---------------------------------------------------------------------------------------
    Line node_view_permissions.module
    ------ ---------------------------------------------------------------------------------------
    65 Call to an undefined method Drupal\Core\Entity\ContentEntityInterface::isPublished().
    ------ ---------------------------------------------------------------------------------------

    [ERROR] Found 1 error

    The above issue has been fixed in the new patch attached here.

  • Status changed to Needs review over 1 year ago
  • 🇮🇳India dineshkumarbollu

    patch #12 worked fine for me and shows 0 compatible issues in local.

  • Status changed to RTBC over 1 year ago
  • 🇮🇳India abhinavk

    I have tested patch #12 and it is working fine without any errors on Drupal 9 (9.5.7) and on Drupal 10 (10.0.3) in my local.

    Moving this to RTBC.

  • 🇮🇳India abhinavk

    I have tested patch #12 and it is working fine without any errors on Drupal 9 (9.5.7) and on Drupal 10 (10.0.3) in my local.

    Moving this to RTBC.

  • 🇺🇸United States loopy1492

    It'd be cool to get a merge of this at least into dev so it can be used in d10 without referencing the mr branch in composer.json.

  • 🇫🇷France OnOff

    (Hello)
    Same as loopy, it will be really helpful !
    (Thks for maintaining btw)

  • 🇺🇸United States Todd Young

    Agreed, looking for clean D10 installable-version, would be very helpful

  • 🇩🇪Germany sleitner

    +1 I'm also looking forward for a tagged Drupal 10 release.

  • 🇬🇧United Kingdom SirClickALot Somerset

    Keen too to see a table D10 release is that's viable.
    Thanks for this highly useful module!

  • 🇷🇺Russia adci_contributor

    Thank you all for your work!

    Merge request !2 by @mattjones86 (includes patch #4 by @mark_fullmer and composer.json by @mattjones86) will be accepted.

    Patch #12 is not necessary, because without it the module works correctly on Drupal 10.0.7 and higher. @sarathkp please provide the steps to reproduce so that we can check it. You will probably need to create a separate issue for this.

  • Status changed to Fixed over 1 year ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024