- First commit to issue fork.
- @mattjones86 opened merge request.
- 🇺🇸United States mark_fullmer Tucson
Note: since this module does not have any additional dependencies or requirements, the addition of the `composer.json` file in the MR above is techincally superfluous, if innocuous.
From https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file → :
If a module does not have any dependencies, or the dependencies are solely other Drupal modules, then a composer.json is not required. However, having a composer.json does not have a negative impact either.
So, in this case, the patch in #4 is still sufficient.
- Status changed to RTBC
almost 2 years ago 9:48pm 7 February 2023 - 🇩🇪Germany sleitner
Both #4 and #7 are working fine. The maintainers should decide if they want a composer.json or not.
- 🇬🇧United Kingdom mattjones86 🇬🇧 GMT+0
composer.json
is actually important if you wish to include a merge request with composer directly:{ ... "repositories": { "node_view_permissions": { "type": "vcs", "url": "https://git.drupalcode.org/issue/node_view_permissions-3288795" }, } ... "require": { "drupal/node_view_permissions": "dev-3288795-automated-drupal-10" } }
Without it, such installation is impossible.
- 🇮🇳India sarathkp
Patch #4 is failing for me in Drupal 10.0.7
Giving the below error:------ ---------------------------------------------------------------------------------------
Line node_view_permissions.module
------ ---------------------------------------------------------------------------------------
65 Call to an undefined method Drupal\Core\Entity\ContentEntityInterface::isPublished().
------ ---------------------------------------------------------------------------------------[ERROR] Found 1 error
The above issue has been fixed in the new patch attached here.
- Status changed to Needs review
over 1 year ago 4:02am 4 April 2023 - 🇮🇳India dineshkumarbollu
patch #12 worked fine for me and shows 0 compatible issues in local.
- Status changed to RTBC
over 1 year ago 11:47am 4 April 2023 - 🇮🇳India abhinavk
I have tested patch #12 and it is working fine without any errors on Drupal 9 (9.5.7) and on Drupal 10 (10.0.3) in my local.
Moving this to RTBC.
- 🇮🇳India abhinavk
I have tested patch #12 and it is working fine without any errors on Drupal 9 (9.5.7) and on Drupal 10 (10.0.3) in my local.
Moving this to RTBC.
- 🇺🇸United States loopy1492
It'd be cool to get a merge of this at least into dev so it can be used in d10 without referencing the mr branch in composer.json.
- 🇫🇷France OnOff
(Hello)
Same as loopy, it will be really helpful !
(Thks for maintaining btw) - 🇺🇸United States Todd Young
Agreed, looking for clean D10 installable-version, would be very helpful
- 🇩🇪Germany sleitner
+1 I'm also looking forward for a tagged Drupal 10 release.
- 🇬🇧United Kingdom SirClickALot Somerset
Keen too to see a table D10 release is that's viable.
Thanks for this highly useful module! - 🇷🇺Russia adci_contributor
Thank you all for your work!
Merge request !2 by @mattjones86 (includes patch #4 by @mark_fullmer and composer.json by @mattjones86) will be accepted.
Patch #12 is not necessary, because without it the module works correctly on Drupal 10.0.7 and higher. @sarathkp please provide the steps to reproduce so that we can check it. You will probably need to create a separate issue for this.
- Status changed to Fixed
over 1 year ago 8:14am 9 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.