- First commit to issue fork.
- @mrddthi opened merge request.
- 🇮🇳India nayana_mvr
Patch #2 does not apply. Got the following error:
Checking patch composer.json... Checking patch header_and_footer_scripts.info.yml... error: while searching for: package: HFS type: module core: 8.x core_version_requirement: ^8 || ^9 configure: header_and_footer_scripts.admin.header error: patch failed: header_and_footer_scripts.info.yml:3 error: header_and_footer_scripts.info.yml: patch does not apply
Verified MR!4 on Drupal version 10.1.x. The patch applied cleanly and I have added the before and after screenshots for reference.
- Status changed to RTBC
over 1 year ago 5:42am 22 February 2023 - First commit to issue fork.
- 🇬🇧United Kingdom Rory Downes
Hi,
Is there any news on getting this merged and preferably a release done?As it is, with composer.json referring to core, it is not possible to apply the patch or even use the dev branch and I will have to make a copy of this module and work with it locally until this is done?
Regards Rory
- 🇬🇧United Kingdom sagraham
Like Rory, keen to see there changes merged and deployed. Subscribing to keep up.
- 🇦🇺Australia akemp_soh
Similarly, would greatly appreciate a merge and deploy on this one.
- 🇮🇳India kishor_kolekar
Please update for Drupal 10 compatibility :)
- 🇺🇸United States aharown07
+1. Appreciate the module but need the D10.
- 🇺🇸United States bgronek
Until a new build is rolled, I have created a patch which you all can apply temporarily for D10 compatibility. It removes the drupal/core versions from composer.json and updates info to include D10.
- 🇮🇳India newswatch Delhi/Bangalore
#17 patch is the simplest I have seen.
For all practical purposes, the module works fine with D 10.1.5
- 🇮🇳India bharath-kondeti Hyderabad
Can we get a D10 release for this module, please ?
- 🇵🇪Peru hatuhay Lima
To apply D10 patch edit your composer json on this lines:
"repositories": [ { "type": "composer", "url": "https://packages.drupal.org/8", "exclude": [ "drupal/header_and_footer_scripts" ] }, { "type": "git", "url": "https://git.drupalcode.org/issue/header_and_footer_scripts-3287867.git" } ],
Then run:
composer require 'drupal/header_and_footer_scripts:dev-3287867-d10-fix'
- 🇪🇸Spain aleix
@Hatuhay Despite this approach will work, it's not recommended and it's better to never add an issue fork git repo as a regular composer repository source. It will lead to unsecure site, as others could write arbitrary code.
If you want to do so, clone the issue fork repository to your own and add your repository instead. - 🇬🇧United Kingdom joehuggans Harrogate, UK
Drupal 10 Release needed by the maintainers, doesn't look like they are responding...
- 🇺🇸United States mlncn Minneapolis, MN, USA
Drupal 9 is End-of-Life so this is major.