Automated Drupal 10 compatibility fixes

Created on 15 June 2022, over 2 years ago
Updated 26 March 2024, 8 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

RTBC

Version

3.0

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • @mrddthi opened merge request.
  • 🇮🇳India nayana_mvr

    Patch #2 does not apply. Got the following error:

    Checking patch composer.json...
    Checking patch header_and_footer_scripts.info.yml...
    error: while searching for:
    package: HFS
    
    type: module
    core: 8.x
    core_version_requirement: ^8 || ^9
    
    configure: header_and_footer_scripts.admin.header
    
    
    error: patch failed: header_and_footer_scripts.info.yml:3
    error: header_and_footer_scripts.info.yml: patch does not apply

    Verified MR!4 on Drupal version 10.1.x. The patch applied cleanly and I have added the before and after screenshots for reference.

  • Status changed to RTBC over 1 year ago
  • 🇮🇳India rassoni Bangalore
  • First commit to issue fork.
  • 🇬🇧United Kingdom Rory Downes

    Hi,
    Is there any news on getting this merged and preferably a release done?

    As it is, with composer.json referring to core, it is not possible to apply the patch or even use the dev branch and I will have to make a copy of this module and work with it locally until this is done?

    Regards Rory

  • 🇬🇧United Kingdom sagraham

    Like Rory, keen to see there changes merged and deployed. Subscribing to keep up.

  • 🇺🇸United States aangel

    A new release would be great, please :-)

  • 🇦🇺Australia akemp_soh

    Similarly, would greatly appreciate a merge and deploy on this one.

  • 🇹🇭Thailand AlfTheCat

    +1

  • 🇺🇸United States gac_solutions

    Please deploy this one :)

  • 🇮🇳India kishor_kolekar

    Please update for Drupal 10 compatibility :)

  • 🇺🇸United States aharown07

    +1. Appreciate the module but need the D10.

  • 🇺🇸United States bgronek

    Until a new build is rolled, I have created a patch which you all can apply temporarily for D10 compatibility. It removes the drupal/core versions from composer.json and updates info to include D10.

  • 🇮🇳India newswatch Delhi/Bangalore

    #17 patch is the simplest I have seen.

    For all practical purposes, the module works fine with D 10.1.5

  • 🇮🇳India bharath-kondeti Hyderabad

    Can we get a D10 release for this module, please ?

  • 🇵🇪Peru hatuhay Lima

    To apply D10 patch edit your composer json on this lines:

        "repositories": [
            {
                "type": "composer",
                "url": "https://packages.drupal.org/8",
                "exclude": [
                    "drupal/header_and_footer_scripts"
                ]
            },
            {
                "type": "git",
                "url": "https://git.drupalcode.org/issue/header_and_footer_scripts-3287867.git"
            }
        ],
    

    Then run: composer require 'drupal/header_and_footer_scripts:dev-3287867-d10-fix'

  • 🇪🇸Spain aleix

    @Hatuhay Despite this approach will work, it's not recommended and it's better to never add an issue fork git repo as a regular composer repository source. It will lead to unsecure site, as others could write arbitrary code.
    If you want to do so, clone the issue fork repository to your own and add your repository instead.

  • 🇬🇧United Kingdom joehuggans Harrogate, UK

    Drupal 10 Release needed by the maintainers, doesn't look like they are responding...

  • 🇺🇸United States mlncn Minneapolis, MN, USA

    Drupal 9 is End-of-Life so this is major.

Production build 0.71.5 2024