Automated Drupal 10 compatibility fixes

Vasyl Vasylkiv → made their first commit to this issue’s fork.

I still got an error in Drupal 10 even though I updated these patch above

Drupal\Core\Entity\Query\QueryException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck(). in Drupal\Core\Entity\Query\Sql\Query->prepare() (line 141 of core/lib/Drupal/Core/Entity/Query/Sql/Query.php).
Drupal\Core\Entity\Query\Sql\Query->execute() (Line: 105)
Drupal\eck\Controller\EckEntityTypeListBuilder->buildRow(Object) (Line: 219)
Drupal\Core\Entity\EntityListBuilder->render() (Line: 23)
Drupal\Core\Entity\Controller\EntityListController->listing('eck_entity_type')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 163)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 686)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

You have to test using the dev release + this MR, some things were already fixed in #3231430: Access checking must be explicitly specified on entity query → .

The change made at https://git.drupalcode.org/project/eck/-/merge_requests/21.diff appear to be satisfactory, as the patch was successfully applied without any conflicts using drupal-lenient, and ECK now functions smoothly with Drupal 10 without encountering any problems. RTBC +1

"patches": {
    "drupal/eck": {
        "#3287130": "https://git.drupalcode.org/project/eck/-/merge_requests/21.diff"
    }
}

The alterations are operating smoothly on Drupal 10.1.x version and have achieved compatibility, yet the drupal-check has detected numerous issues. It would be beneficial if these issues could be resolved before the new release.

It would be greatly appreciated if the module maintainers could create a release for Drupal 10 of this module. It is widely used on many websites and will be advantageous during the upgrade process from Drupal 8 or 9 to 10.

Thank you.

The merge request was merged with some changes on commit:
1) Fixed 'config_export' keys to match the schema;
2) Removed PHP 8.1 requirement - not sure why it was introduced, but we should be alongside with Drupal core;
3) Removed references to 'entity_reference' module, because its code was merged into other core components;

Test bot is happy so am I :)

By the way, until the new release is available, you can use DEV version.

Thanks!

Made a couple of compatibility changes with this patch.

1. In MigrateEckTest.php, changed the order of ->accessCheck(FALSE)->count()-> to ->count()->accessCheck(FALSE)->, otherwise phpstan throws a deprecation error
2. In UnitTestBase.php, changed setMethods to onlyMethods. setMethods is deprecated, and onlyMethods or addMethods should be used instead. I believe this situation calls for onlyMethods, though correct me if I'm wrong.

@kelly.m.jacobs this issue is already fixed/merged, maybe open a new one if anything was forgotten.

Automatically closed - issue fixed for 2 weeks with no activity.