Automated Drupal 10 compatibility fixes

I can confirm, Patch #3 works well.

Drupal 10.0.7
PHP 8.1.6

When trying to update a Drupal 9 website to 10 , composer needs first to install the module and then apply the patch, but the module can't be installed because it's not compatible with Drupal 10, so I created a fork to download the module from until we have the new release.

Hello,

Can we have a D10 compatible release please ?

Thanks a lot

@Abdalhamid : can't update to D10 even with your branch :

 Problem 1
    - drupal/betterlogin 1.2.0 requires drupal/core ~8.0 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev] but it conflicts with your root composer.json require (^10).
    - drupal/betterlogin[1.3.0, ..., 1.x-dev] require drupal/core ^8 || ^9 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but it conflicts with your root composer.json require (^10).
    - Root composer.json requires drupal/betterlogin ^1.2.0 -> satisfiable by drupal/betterlogin[1.2.0, ..., 1.x-dev].

Thanks

Providing updated patches.
For 8.x-1.6 : betterlogin-d10-compatibility-3286226-18-1.patch →
For 8.x-1.x-dev : betterlogin-d10-compatibility-3286226-18.patch →

Please review.

thanks @yogeshsevak, patch #3 didn't work for me but yours are ok, perfect :)

Hi,

Anybody can help please ?

Thanks :-)

Hopping for a commit and a tag release.

Facilitate a seamless upgrade process while maintaining compatibility with both Drupal 9 and Drupal 10 using a unified code base.

Have the composer.json file back which was added by AbedAlhamid Ahmad to let the issue fork work with composer, but with Drupal 9 and Drupal 10 support.

The composer.json file will not be needed when merged to the 8.x-1.x branch.
I'm ok with having it tho.

Vishal Choudhary → made their first commit to this issue’s fork.

Hi,

Will you release a stable version of the module on d10? to up my websites with mass update :)

Thanks

The commit added in #25 adds better_login_form_config.module and better_login_form_config.info.yml. I don't think we need that. @Vishal Choudhary can you revert those changes?

Hi,

Yeah but composer doesn't find the new version on the repo... so i have to update manually.

Thanks

Hi all,

Thanks a lot for your work.

I can confirm the current version of the fork (https://git.drupalcode.org/issue/betterlogin-3286226/-/tree/3286226-auto...) works on my Drupal 10.1.2 test install.

What's needed to go forward with the release of the updated package?

Hoping for a commit and a release
To having a smooth upgrade for projects.

Hi everyone,

Just wanted to check in to see what the status is for the D10 release of the module. The code changes listed in morepolarbears's comment works great on my D10 site. What needs to happen to get a release of this code?

Thanks in advance!

I gave a look at this in a ddev D10 env, and it indeed installed (after adding the repository entry and requiring the module accordingly); however, I found that there may be some styling updates desirable? As in: It seems like the flat 20% width in the CSS (https://git.drupalcode.org/project/betterlogin/-/blob/dfdd367b3f3937a01b...) causes overflow issues, with the username/password/etc fields being partially hidden with the default configuration.

That said, further examined our internal environment and found that we weren't actually using this module despite having it installed and enabled as gin_login was taking precedence; so in our instance, moving to remove betterlogin from our environment.

Seems that no release for this module.
Used it for quite long time.
This is a blocker for upgrading to Drupal 10
Please, help us to have a smoother upgrade way
Only by committing and a tag release.

This is a direct fork for the Better Login module
https://packagist.org/packages/vardot/betterlogin
https://github.com/Vardot/betterlogin

Following with changes from
📌 Automated Drupal 10 compatibility fixes Needs work
Started this Fork module on the 2.0.x branch
Switching to use the forked version

Dropped the use of this module in all new projects.
Hoping for a new branch 2.0.x.
Only help having a smooth upgrade process for old projects

Let's start by getting this RTBC first, and then try to ping the maintainers for a new release.

The code based referenced earlier works. We just need to get the module maintainers to cut a release with the updated code.

https://git.drupalcode.org/issue/betterlogin-3286226/-/tree/3286226-auto...

First stable release created for Drupal 10 - https://www.drupal.org/project/betterlogin/releases/2.0.0 →

Very much sorry for not doing beforehand D10 released.

Automatically closed - issue fixed for 2 weeks with no activity.