Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 15 June 2022, over 2 years ago
Updated 12 July 2023, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Comment almost 2 years ago →
    🇮🇳India sheetal-wish Indore

    I have applied this patch and now it's D10 compatible but I am not able to download AMP library via composer it's showing me this error:

    lullabot/amp[2.0.1, ..., 2.0.3] require guzzlehttp/guzzle ~6.1 -> satisfiable by guzzlehttp/guzzle[6.1.0, ..., 6.5.x-dev].
    - lullabot/amp 2.0.0 requires sebastian/diff ^1.2 || ^2 || ^3 -> found sebastian/diff[1.2.0, ..., 1.4.x-dev, 2.0.1, 2.0.x-dev, 3.0.0, ..., 3.0.x-dev] but these were not loaded, likely because it conflicts with another require.
    - guzzlehttp/guzzle[6.4.0, ..., 6.5.7] require guzzlehttp/psr7 ^1.6.1 -> found guzzlehttp/psr7[1.6.1, ..., 1.x-dev] but these were not loaded, likely because it conflicts with another require.
    - guzzlehttp/guzzle 6.5.4 requires symfony/polyfill-intl-idn 1.17.0 -> found symfony/polyfill-intl-idn[v1.17.0] but these were not loaded, likely because it conflicts with another require.
    - guzzlehttp/guzzle[6.5.8, ..., 6.5.x-dev] require guzzlehttp/psr7 ^1.9 -> found guzzlehttp/psr7[1.9.0, 1.x-dev] but these were not loaded, likely because it conflicts with another require.
    - Root composer.json requires lullabot/amp ^2.0 -> satisfiable by lullabot/amp[2.0.0, 2.0.1, 2.0.2, 2.0.3]

    Can someone please help me to resolve this.
    Thank you

  • First commit to issue fork.
  • Comment over 1 year ago →
    e0ipso Can Picafort

    @sheetal-wish it seems you have some other dependency incompatibility that entangles with Guzzle.

  • Comment over 1 year ago →
    🇷🇺Russia pick_d

    Probably dumb question, but

    How does one upgrade to Drupal 10 when there is no suitable amp release? I mean, I patched the module, and upgrade_status shows that everything is fine and I should I be able to upgrade, however when I try to upgrade, I get this:

    - drupal/amp 3.6.0 requires drupal/core ^8.7.7 || ^9 -> satisfiable by drupal/core[8.7.7, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev].

  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update over 1 year ago
    Waiting for branch to pass
  • Comment over 1 year ago →
    🇧🇷Brazil adinancenci

    A small modification to patch #10 to make AmpCssCollectionRenderer compatible with CssCollectionRenderer

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 8.1 & MariaDB 10.3.22
    last update over 1 year ago
    Patch Failed to Apply
  • Comment over 1 year ago →
    🇭🇺Hungary szato

    @adinancenci

    You have wrong references in #18 patch file, e.g.:
    diff --git a/web/modules/contrib/amp/amp.info.yml b/web/modules/contrib/amp/amp.info.yml

    should be:
    diff --git a/amp.info.yml b/amp.info.yml

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 8.1 & MariaDB 10.3.22
    last update over 1 year ago
    Composer require failure
  • First commit to issue fork.
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update over 1 year ago
    Waiting for branch to pass
  • @stborchert opened merge request.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update over 1 year ago
    34 pass, 12 fail
  • Comment over 1 year ago →
    🇧🇾Belarus dakruchko
  • Comment over 1 year ago →
    System Message

    The last submitted patch, 22: amp-3286062-22.patch, failed testing. View results →
    - codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • Comment over 1 year ago →
    🇧🇾Belarus dakruchko
  • Comment over 1 year ago →
    e0ipso Can Picafort

    This looks good to me!

    My main hesitation was + "lullabot/amp": "^1.1 || ^2.0 || dev-main",, so I tagged a release in the library to avoid that. I will fix this on commit.

  • Comment over 1 year ago →
    System Message
  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    e0ipso Can Picafort

    Thanks everyone!

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024