- πΊπΈUnited States andy-blum Ohio, USA
It's unfortunate that this issue has been ignored this long - new patch attached that adds a README.md with Mike's words in #6 and Andrew's corrections in #8
- First commit to issue fork.
- @fanton opened merge request.
- πΊπΎUruguay fanton Uruguay
#11 looks good. I fix some typos, apply Drupal coding standards, and committed the README.md file, please review it!
- First commit to issue fork.
- Status changed to RTBC
over 2 years ago 2:49pm 13 March 2023 - πΊπΈUnited States smustgrave
Wording seems correct.
Was racking my brain to think of a different file name since none of the other themes have a README.md but couldn't come up with anything. But also think README may be the best as that's what users will be use to and will read it, like I did.
- Status changed to Needs work
over 2 years ago 9:35am 31 March 2023 - π¨π¦Canada mgifford Ottawa, Ontario
In ripping this out of MD to send to the NFB I noticed a few issues.
Too late for me to do this now, but put them here. Basically:
is was isn't a thing.
This theme was created in memory of Rachel Olivero.
an vs a
to make this theme an example.
and "more better" is bad. Just Better is best:
...should you find ways to make it a better user experience for everyone.
Sorry, gotta leave it there for now. Can someone roll this into a new patch.
Just little stuff that jumped out as I was looking at this in a word processor.
- π¨π¦Canada mgifford Ottawa, Ontario
I've got approval and appreciation from the NFB.
- Status changed to RTBC
over 2 years ago 1:27pm 31 March 2023 - π«π·France nod_ Lille
- π¨π¦Canada mgifford Ottawa, Ontario
That's confusing. But yes, it is in the MR. Thanks @nod_
- Status changed to Needs work
over 2 years ago 3:38pm 31 March 2023 - Status changed to Needs review
over 2 years ago 8:50pm 31 March 2023 - πΊπΈUnited States mherchel Gainesville, FL, US
Looks like the two words the 10.1.x patch adds are already present in 9.5.x.
This patch simply adds the readme.
- Status changed to RTBC
over 2 years ago 9:50pm 31 March 2023 - Status changed to Fixed
over 2 years ago 9:52pm 31 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.