I agree, this is still an issue, but the problem occurs, if the icon is configured to be on the RIGHT side not on the left (so appended, not prepended).
- πΊπΈUnited States W01F
The current patch doesn't seem to allow for both left and right placement. We already have the UI option for which to use (Left/Right) - we just need to add proper CSS for each.
Current code only works for left.
Patch makes it only work for right.
- Status changed to Needs work
3 days ago 2:16am 26 June 2024 - πΊπΈUnited States smustgrave
Think the solution would be to add a class to the svg based on the placement and update css around that
- Status changed to Needs review
1 day ago 11:21pm 26 June 2024 Why so explicit?
This should be enough?
[data-extlink-placement='append'], [data-extlink-placement='after']{ padding-left: 0.2rem; }
- πΊπΈUnited States smustgrave
Lack of sleep but yea that's definitely better.
-
smustgrave β
committed 90270408 on 2.0.x
Resolve #3274434 "Padding should be"
-
smustgrave β
committed 90270408 on 2.0.x
- Status changed to Fixed
15 minutes ago 3:13pm 28 June 2024 - πΊπΈUnited States smustgrave
Planning a beta1 release of 2.0.x soon and wanted to include this.