Add pagination to the workspace manage page

1) Drupal\Tests\workspaces\Functional\WorkspaceTest::testWorkspaceManagePage
Behat\Mink\Exception\ExpectationException: Link with label Term 1 found.
/builds/issue/drupal-3273461/core/tests/Drupal/Tests/WebAssert.php:580
/builds/issue/drupal-3273461/core/tests/Drupal/Tests/WebAssert.php:350
/builds/issue/drupal-3273461/core/modules/workspaces/tests/src/Functional/WorkspaceTest.php:224
/builds/issue/drupal-3273461/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
ERRORS!
Tests: 9, Assertions: 211, Errors: 1.

Test-only feature shows test coverage

I don't have 50 workspaces :) but based on how I've seen other parts of core do this this appears correct.

@smustgrave, you don't need 50 workspaces, just to edit >50 entities in a workspace :P

One thing I don't really like about this MR is the large number of arguments of WorkspaceAssociation::getTrackedEntities(), but I didn't have any better idea. Maybe a new method is needed for getting a "paginated" list of tracked entities, without the ability to filter by entity type ID and entity ID... not sure.

Is there any reason why we're not using \Drupal\Core\Database\Query\PagerSelectExtender and \Drupal\Core\Database\Query\TableSortExtender?

@alexpott because WorkspaceAssociation::getTrackedEntities() is a "low level" API function that shouldn't be influenced by any global pager. Maybe this is another point in favor of adding a separate method for this listing :)

Maybe we could add getTrackedEntitiesAsQuery() and return the query object for us to do stuff with - or just not use it... but given \Drupal\workspaces\WorkspaceAssociation::TABLE - maybe this returning a query object you to do stuff to would work nicely.

Gonna put this back to needs review while @amateescu has a think.

Per slack from @amateescu

Implemented the separate method as discussed above, and it's looks much better!

Regarding \Drupal\Core\Database\Query\TableSortExtender, we can't use it because the data displayed in the table is coming from the individual revision objects, not from the `workspace_association` table.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Btw, a quick`n`dirty way to test this MR is to edit a couple of entities in a workspace and manually change WorkspaceViewBuilder.php::$limit to 1 :)

I did just that haha thanks for the pointer

I applied some minor change to the MR for the return type but overall rest of the changes appear good

Committed and pushed f7950eb418 to 11.x and fdac75b8b0 to 10.3.x. Thanks!