- 🇦🇺Australia VladimirAus Brisbane, Australia
Might have been fixed by @jannakha changes.
Please review and update. - Status changed to Needs work
over 1 year ago 11:50am 11 July 2023 - 🇮🇳India ravi kant Jaipur
I have reviewed above changes. Two issues have fixed but two issues did not fixed.
Fixed issues -
Not Fixed issues -
- 🇮🇳India snehal-chibde
Hello, the remaining 2 issues have been resolved. Please review the patch.
Refer screenshots. - Status changed to Needs review
over 1 year ago 10:00am 20 July 2023 - Status changed to Needs work
over 1 year ago 11:12pm 6 August 2023 - 🇦🇺Australia jannakha Brisbane!
Can you please use git workflow by creating issue fork and adding your changes there?
Try to minimise any unnecessary code:
- bootstrap5_form_system_file_system_settings_alter() is not requiredsee how Claro has its implementation - not additional tags:
- 🇮🇳India snehal-chibde
Hello @jannakha, here is a patch to resolve the above issue without the function bootstrap5_form_system_file_system_settings_alter.
- Status changed to Needs review
over 1 year ago 10:20am 22 August 2023 - Status changed to Needs work
over 1 year ago 1:23pm 22 August 2023 - 🇦🇺Australia jannakha Brisbane!
Hi @snehal-chibde
the patch looks good, but as Bootstrap is a variables based theme, 'bold' definition can be different for each sub-theme (depending on definition of $font-weight-bold variable)
See here:
https://git.drupalcode.org/project/bootstrap5/-/blob/3.0.x/dist/bootstra...Similar to this:
https://git.drupalcode.org/project/bootstrap5/-/blob/3.0.x/scss/drupal/_...Then if sub-theme is created and $font-weight-bold is set to something other then default - then it will apply the new value.
Please use $font-weight-bold instead of 'bold'.
- Status changed to Needs review
over 1 year ago 7:35am 23 August 2023 - Status changed to RTBC
over 1 year ago 1:10am 24 August 2023 - 🇦🇺Australia VladimirAus Brisbane, Australia
Looks good!
Thank you for your contribution. 🍰 -
VladimirAus →
committed 02a1d989 on 3.0.x
Issue #3272858 by snehal-chibde, VladimirAus, ravi kant, jannakha: Admin...
-
VladimirAus →
committed 02a1d989 on 3.0.x
-
VladimirAus →
committed 02a1d989 on 4.0.x
Issue #3272858 by snehal-chibde, VladimirAus, ravi kant, jannakha: Admin...
-
VladimirAus →
committed 02a1d989 on 4.0.x
Automatically closed - issue fixed for 2 weeks with no activity.