- 🇭🇺Hungary pasqualle 🇭🇺 Budapest
The patch does not apply to latest 2.x-dev.
- 🇮🇳India Preeti.chawla
I have created new patch which will work in latest 2.x.dev. By this Toolbar menu will be visible in Gin theme. Please apply and test for same.
- Status changed to Needs review
almost 2 years ago 10:21am 21 July 2023 - last update
almost 2 years ago Patch Failed to Apply - last update
almost 2 years ago 1 pass - Status changed to Needs work
almost 2 years ago 1:09pm 24 July 2023 - 🇦🇺Australia elgandoz Canberra
This fix currently throws an error when using the classic toolbar.
- Status changed to Needs review
almost 2 years ago 4:07pm 24 July 2023 - last update
almost 2 years ago 1 pass - 🇮🇹Italy Giuseppe87
+1 for the #8 patch: without it the menù with Gin isn't shown, with the patch it works.
- Status changed to RTBC
10 months ago 8:34am 2 July 2024 - 🇩🇪Germany jan kellermann
Patch from comment #8 works for us. Thank you very much.
- First commit to issue fork.
- Merge request !6Changes based on patch from DO-3271757-8 based on the work from users elgandoz and pasqualle. → (Open) created by dydave
- 🇫🇷France dydave
Thanks everyone for the great help on this issue!
I've rolled in the changes from the latest patch at #8 in merge request MR!6 to get the work started on this issue.
I'm not exactly sure I understand how to reproduce the problem here, could somebody please provide more details?
For example, which type of Toolbar is used with the Gin Theme?
Any other potential modules?
Where is this classtoolbar-menu-administrationexactly used in the Gin theme? What causes the issue exactly?
(Any link code references pointing to the Gin repo)Could we please get some screenshots as well?
Additionally, I'm still seeing the issue mentioned above at #3 with extra empty items, when enabling Gin, with any of the Gin Toolbar selected (see in Gin theme settings):
I'm seeing the same exact issue with any of the Toolbar menu items created and displayed in the Toolbar.Could we try fixing this issue as well as part of a GIN Theme compatibility fix?
Any help, comments, testing and feedback would be greatly appreciated.
Thanks in advance!