unmasquerade link shows in menu when not masquerading

Working on the test coverage.

Some minor improvements to the tests were committed in 📌 Extend test coverage to note when the pages should give 200 or 403 errors Fixed .

Along with 🐛 Masquerade as blocked user returns a 403 error and logs out the user RTBC , I think ✨ Remove special logic for user 1 in SwitchAccessCheck RTBC is relevant to this.

I can work on some additional test coverage for this, but I'd like to see the test changes from #3258364 get committed first, then we can build from there.

Some improved test coverage that sits on top of the code from 🐛 Masquerade as blocked user returns a 403 error and logs out the user RTBC ; the tests don't pass yet because the "Unmasquerade" link shows for user 1 even if they're not masquerading.

This is a core issue, I just stopped to close similar issues in favour of 🐛 [regression] Do not bypass route access with 'link to any page' permissions for menu links Fixed

Rerunning the tests with the patch from #2463753 applied makes the tests all pass as expected. So maybe we should mark this "postponed" and pile up on the core issue?

Good idea, thank you!

Updated IS

I think once we can solve the core issue that this could be committed as is. It might be worth documenting the core issue, until it's fixed.

It might be interesting to add gitlab-ci support to the project and to use the composer-patches functionality → to add the core patch, to confirm the fix.

Core issue fixed in upcoming 10.3 🐛 [regression] Do not bypass route access with 'link to any page' permissions for menu links Fixed

#24 should pass when it runs against 10.3.x, but that isn't available as an option for drupalci.

The patch in #24 does not apply to 2.0.0 or to the current 2.x-dev. The patch from #20 still works.