- Issue created by @DamienMcKenna
- πΊπΈUnited States DamienMcKenna NH, USA
I'll provide a patch for this in a moment.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:57pm 27 July 2023 - last update
over 1 year ago 5 pass - πΊπΈUnited States DamienMcKenna NH, USA
The permission system should catch everything already.
- Status changed to RTBC
over 1 year ago 11:46pm 27 July 2023 - π«π·France andypost
As tests show it's right and one more clean-up for related π Add a container parameter that can remove the special behavior of UID#1 Fixed
- πΊπΈUnited States DamienMcKenna NH, USA
Have been building on the test coverage from π Masquerade as blocked user returns a 403 error and logs out the user RTBC and from what I can see the "Unmasquerade" link is always shown for user 1, even though $this->masquerade->isMasquerading() reports FALSE in UnmasqueradeAccessCheck::access(). Any thoughts on how we could resolve that? The attached patch sits on top of #3258364-31.
- πΊπΈUnited States DamienMcKenna NH, USA
I wonder if the link showing up is because of caching, or because of something else, maybe something related to permissions?
And do we want to wrap that problem into this issue or spin it off as a separate issue?
- πΊπΈUnited States DamienMcKenna NH, USA
Answering my own question: let's focus this issue on SwitchAccessCheck, and we'll do a separate issue on the unmasquerade link.
- πΊπΈUnited States DamienMcKenna NH, USA
We can do the unmasquerade link problems in #3271001.
- First commit to issue fork.
- Merge request !16Remove special logic for user 1 in SwitchAccessCheck β (Open) created by mstrelan
- Status changed to Needs review
6 months ago 1:21am 3 September 2024 - Status changed to RTBC
6 months ago 3:34am 3 September 2024