Deprecate passing non-string parameters to \Drupal\Core\Utility\Token::scan then implement typehint

Believe the change record needs to be in the trigger_error no?

Good point, the example I copied from didn't have one but you're right, that should be there.

That was quick! Looks good to me.

We should be adding test coverage of this deprecation because it contains some logic. I looked for existing test coverage of Token::scan() and I found core/modules/system/tests/src/Functional/System/TokenScanTest.php which is a pointless functional test - it can be a unit test - and I found a unit test \Drupal\Tests\Core\Utility\TokenTest - which sets up a token service for us to use in testing - so I moved everything there.

Tested the Patch on #22 working fine for me, D10

Committed f2e1dcd and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.