- 🇩🇪Germany Grevil
I cleaned up a bit.
- I fixed the codestyle issues in 📌 Fix the errors/warnings reported by PHP_CodeSniffer Fixed and renamed a few methods in the process
- I refactored a lot of unnecessary overhead through 📌 Test the module and overhaul its code in the process. Fixed
I wouldn't agree to split the PWAController in different Controllers. Although, we could split off a few methods that aren't called through the routing.yml.
I'll adjust the issue description on what is left to do (or if we can close this issue entirely).
- 🇩🇪Germany Grevil
Adjusted everything that's already fixed through other issues. I also removed the suggestion to split off the PWAController into smaller Controllers. I'd say this change would bloat the module too much, but as mentioned before, totally for a partial split off of some methods, that shouldn't reside in a Controller anyway! 👍
Still a bunch of issues left! But at least the pile of shame got smaller!
- Issue was unassigned.