Test the module and overhaul its code in the process.

HUGE ++++++++++ on this. The module is really unstable and needs a lot of tests be become far more stable. Please help, Drupal community! :)

Tests should still be implemented against 2.x and cherry-picked into 3.x then.

Agreed. I wish I had more time for this, but if anyone is able to help and needs some advice or examples, please check the other projects I'm a maintainer on via my profile, especially Config Enforce and Config Enforce Devel; they have a bunch of tests and more being added as time goes on.

What should be tested:

1. Install / uninstall
2. manifest.json present on the expected pages
3. Permissions
4. Contents of the manifest.json to match the values from the settings page
5. Returned paths / URLs from the manifest.json working, e.g. images
6. Drupal login / logout with PWA enabled, as there were issues in the past

Once tests are in place, please check the list of issues and close the ones that are proven to work now by tests. I think there are several that have been fixed in the meantime or are duplicates.

No idea who came up with the 'getDisplayValue()' logic... Removed that unnecessary overhead.

Alright, this MR does a LOT and eventually feels a bit out of scope, but most changes here were done, while checking failing tests and seeing some questionable code in the process. Hence, I renamed the issue title. Although it won't break any existing sites having the module enabled.

I couldn't yet write tests for the service worker, but commented why in a comment. I also didn't write tests for the app icon settings, hence they are completely borked anyway and will get refactored in a separate issue.

Please review!

Small update hook additions, update works as expected!

Thanks @Grevil - great work! Just some minor comments to fix.

For the Service Worker tests: Please separate that as issue, I don't think it's that important and might be really hard to run automated tests against. Maybe even impossible. Shouldn't be our priority here.

Adjusted everything accordingly, please rereview!

Great work, RTBC!

Automatically closed - issue fixed for 2 weeks with no activity.