Improve the readability of the "Add" button in the modal window

Created on 28 February 2022, over 2 years ago
Updated 28 March 2024, 3 months ago

Hello,
First of all, I would like to thank you for the realization of the module which is very interesting.

I installed it in its version 8.x-1.0, and I notice that the buttons within the modal are not defined as primary buttons. As a result this displays the horizontal bar below the button and makes it difficult to read the text. I suggest you add the "button--primary" class to each button.
I attach a before

and after

screenshots.

Sincerely
Marc

🐛 Bug report
Status

Needs review

Version

1.0

Component

User interface

Created by

🇷🇪Réunion Martygraphie Saint-Denis (Réunion)

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇻🇳Vietnam phannphong Ho Chi Minh City

    I can confirm that the patch #2 is good. But the patch is fixed only for "Add" button without fixing overlap if we have many paragraphs (at least we have more than 1 line) in the modal. It's referenced in the issue CSS overlap in D10 Claro 🐛 CSS overlap in D10 Claro Fixed

  • Status changed to Needs review 3 months ago
  • 🇺🇸United States greggles Denver, Colorado, USA

    Since there's a patch it should be in needs review status.

    @phannphong do you feel this patch and the D10 Claro path work well together?

  • 🇻🇳Vietnam phannphong Ho Chi Minh City

    @greggles, yes, it works well.

Production build 0.69.0 2024