Enable declaration-block-no-duplicate-properties in Stylelint

Comment over 1 year ago →
🇬🇧United Kingdom longwave UK
The blockers landed, there are a few duplicate declarations we can clean up here.
Status changed to RTBC over 1 year ago5:11pm 27 February 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Change looks good. Have seen this once before so glad to see we got a check now
First commit to issue fork.
@gauravvv opened merge request.
Comment over 1 year ago →
🇮🇳India Gauravvv Delhi, India
Patch #2, is not applying. re-rolled the patch for 10.1.x
Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Not currently mergeable.
Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Not currently mergeable.
Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Not currently mergeable.
Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Not currently mergeable.
Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Not currently mergeable.
Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Not currently mergeable.
Status changed to Needs work over 1 year ago4:02pm 30 April 2023
Comment over 1 year ago →
🇬🇧United Kingdom longwave UK
Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Not currently mergeable.
@gauravvvv opened merge request.
Status changed to Needs review over 1 year ago4:07am 1 May 2023
Comment over 1 year ago →
🇮🇳India Gauravvv Delhi, India
Status changed to Needs work over 1 year ago10:19pm 1 May 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
MR is showing as unmergable.
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Custom Commands Failed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,371 pass
Status changed to Needs review over 1 year ago7:02am 3 May 2023
Comment over 1 year ago →
🇮🇳India sagarchauhan
Comment over 1 year ago →
🇺🇸United States smustgrave
Reroll seems good.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,378 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,379 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,380 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,383 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,395 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,399 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,399 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,400 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,409 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,409 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,415 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,420 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,420 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,401 pass, 4 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,429 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,430 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
4:00
2:44
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,430 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,436 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,436 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,441 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,442 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,443 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,443 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,443 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,439 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,439 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,443 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,444 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,446 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,446 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,446 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,446 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,450 pass
Comment about 1 year ago →
🇫🇮Finland lauriii Finland
Should we have a CR for this? I'm also wondering if no duplicate properties should be part of the coding standards in case that's something we're enforcing here: https://www.drupal.org/docs/develop/standards/css/css-formatting-guidelines → ?
Comment about 1 year ago →
🇺🇸United States smustgrave
Do we do CRs for other rules? https://www.drupal.org/project/drupal/issues/3144854 → we didn't do a CR for removing?
Status changed to RTBC about 1 year ago2:33pm 27 July 2023
Comment about 1 year ago →
🇺🇸United States smustgrave
Not sure a CR is needed, unless we do it for others? Going to post into #coding-standards to see if it's something that should be included.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,454 pass
Status changed to Needs work about 1 year ago7:40am 29 July 2023
Comment about 1 year ago →
🇫🇮Finland lauriii Finland
Removing stylelint rule is different from adding one because removing the rule shouldn't break anything for anyone. We have filed CRs when we've added additional stylelint checks in the past. For example: https://www.drupal.org/node/3041002 → .

Enable declaration-block-no-duplicate-properties in Stylelint

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities