checkConfigSchema() gives unclear error if top-level config type is wrong

// We'd like to verify that the top-level type is either config_base, // config_entity, or a derivative. The only thing we can really test though // is that the schema supports having langcode in it. So add 'langcode' to // the data if it doesn't already exist.

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Status changed to Needs review over 1 year ago2:26pm 19 July 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,748 pass, 6 fail
Comment over 1 year ago →
🇧🇪Belgium borisson_ Mechelen, 🇧🇪
If I understand this issue correctly, I think this should be the fix for it? Haven't fixed any of the tests yet, because I'd first like to get some feedback on the new message first.
I also added a newline in the output, to ensure that the output should be easier to read.
Comment over 1 year ago →
System Message
The last submitted patch, 7: 3265328-7.patch, failed testing. View results →
Status changed to Needs work over 1 year ago5:17pm 19 July 2023
Comment over 1 year ago →
🇬🇧United Kingdom joachim
That's not really it. My point is that the comment says that the top-level type should be one of either config_base, config_entity, or a derivative.

So the error message should say "this should be one of either config_base, config_entity, or a derivative, but it was something else instead".

checkConfigSchema() gives unclear error if top-level config type is wrong

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities