- Merge request !6Issue #3262280: Headers in references tables do not use 'th' elements → (Closed) created by Liam Morland
Hi @Liam Morland
Tested patch on branch 3.0.x with 🐛 References table has no header for bibcite_links Fixed .
Got an error.Drupal\Tests\bibcite_entity\Functional\BibciteEntityTest::testReferenceTable Behat\Mink\Exception\ElementNotFoundException: Element matching xpath "//div[contains(@class, "bibcite-reference-table")]//tr[td[text() = "Download citation"]][td//a[text() = "Google Scholar"]]" not found
.
We plan to fix it later.
You can update your MR if you know the way how it should be fixed.
Thank you.- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Probably just replacing
td
withth
in the test. I don't really have time to investigate; I work for a new employer now and we are not usingbibcite
. -
hxdef →
committed 37127c0d on 3.0.x authored by
Liam Morland →
Issue #3262280: Headers in references tables do not use 'th' elements
-
hxdef →
committed 37127c0d on 3.0.x authored by
Liam Morland →
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
It should probably only be the
title
row that becomesth
. - Status changed to Fixed
8 months ago 8:31am 23 April 2024 - Status changed to Needs work
8 months ago 1:23pm 23 April 2024 - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
The change as it was committed makes all the table cells
th
. It should be the first column that isth
and the second still atd
. This is what I did in my merge request. - Status changed to Fixed
8 months ago 9:10am 26 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.