Missing schema

I was running into this same issue, pulled in this patch, and now my tests are passing again. I think this should be added into this module! Thanks @heddn!

I see that a schema was merged in as part of the v8.1.3 release, but it is not the same as the patch here, and the published fix does not resolve my schema errors, but the patch does.

Needs a reroll.

Rerolled patch #7, please review it.

Thanks!

This patch now no longer works for me...

The recent commit to this project added a schema, but it does not appear to be correct. This commit attempts to define every property of the solr connector, whereas the patch in #7 in this issue was extending the plugin.plugin_configuration.search_api_solr_connector.standard schema.

So now, when I run this project, I get the following error...

Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for search_api.server.pantheon_solr8 with the following errors: search_api.server.pantheon_solr8:backend_config.connector_config.solr_version missing schema, search_api.server.pantheon_solr8:backend_config.connector_config.http_method missing schema, search_api.server.pantheon_solr8:backend_config.connector_config.jts missing schema, search_api.server.pantheon_solr8:backend_config.connector_config.solr_install_dir missing schema

In my opinion, the commit that was merged to the project (linked above) should be reverted, and the patch from #7 above should be committed in it's place.

I'm all confused on the branching strategy here. There's a 3.x branch, an 8.0 and 8.1 branch. I've re-rolled the patch above to apply on 8.1.x. Some version of it was already committed to 3.x and 8.0.x. But no version of a schema exists yet for 8.1. Now we have one.

OK, 8.1.x is 9 commits behind 8.0.x. So I _think_ that 8.0.x is actually the proper branch. Switching over to that instead.

I'm testing and verifying this patch for merge into the project. The patch itself looks good, but I'm having some trouble reproducing the original issue. After spinning up a fresh Drupal 10 site, enabling the various Search modules, exporting configuration, making a small change, and then importing configuration, I get no errors. Can you shed some additional light on what steps cause the issue? Thank you!

For me, this is an automated testing only issue. When you run PHPUnit tests, part of the testing procedure ensures that all config you are importing has a valid schema, and since the schema being provided by this module is being reported as invalid, when using this module as part of an automated test, the test always fails.

So as an example, if I have a my_module.info.yml, and in my dependencies of the module, I list search_api_pantheon, and then I have a Functional test in my module, my test will fail 100% of the time.

So to reproduce, you can probably just add a FunctionalTest to your project, and that should start to fail.

I also don't think you need all of what is included in the latest patch here. The PR that's open on the Github.com repo (github.com/pantheon-systems/search_api_pantheon/pull/169/files) actually solves the problem for me.

Understood, thank you for that information, I need to double check our current branch/release strategy and verify the PR, but I don't imagine any issues getting this in shortly unless something goes terribly awry.

Issue resolved as of the 8.1.4 release.

This still isn't fixed. There is reference to skip_schema_check in config/install/search_api.server.pantheon_solr8.yml that has zero reference in a schema file.

And I don't know where to start now with a patch. The tag 8.1.4 has changes not seen in 8.x-1.x, 8.0.x, 8.1.x, 8.x, nor 3.0.x.

Where is the code managed for this project?

@heddn - they manage externally at https://github.com/pantheon-systems/search_api_pantheon - does that help at all?

This did the fix the issue for my team. Isn't the `skip_schema_check` reference coming from here...?
https://git.drupalcode.org/project/search_api_solr/-/blob/4.x/config/sch...

Actually #23 is correct. I had to re-order the config massively to match solr's schema, but that got it passing green again.

That said, it would be useful to get the project page update with the link to where to post patches. Also, it would be good to clean-up branches and tags so it is more clear where to contribute to the code.

Automatically closed - issue fixed for 2 weeks with no activity.

I added some notes to the project page about the supported branches and added a link to the Pantheon issue queue. And yes, the branching is a bit of a mess, unfortunately :-\