Business Rules 2.0.0-beta2 release plan D10 compatible

I've just fixed the following error reported to me by upgrade_status module after applying MR patch.

Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

Just fixed the following error which happens when editing entity fields of certain types: link, color, etc:

Fix error: Typed property Drupal\field\Entity\FieldConfig::$original must not be accessed before initialization in business_rules_field_widget_single_element_form_alter() (line 293 of modules/contrib/business_rules/business_rules.module)

I've taken the code to fix it from #3286389 patch (MR13). In that issue, they use the same piece of code multiple times in business_rules.module but I only applied it in the line 293 because this line was the only one with property_exists checking. I've been doing some testing and in the other cases the access to original property doesn't fail.

Just enabled testing. All testing errors needs to be fixed.

As expected, the latest commit didn't pass the composer validation because dbug hasn't an official D10 release yet. We can use lenient on local environment but I don't know if GitlabCI can be configured to use it. We need to specify this dependency to pass all the tests.

I'm just rerunning pipeline again since we already have a Drupal 10 compatible version of "dBug for Drupal".

@lexsoft Which issues are included on your first commit of MR15? Are the ones listed under Proposed resolution?

@rcodina,

The MR15 includes all of this:

"drupal/business_rules": {
                "Issue #3239152: Drupal 9 - Deprecated code": "https://www.drupal.org/files/issues/2021-10-29/deprecated-entity-query-3239152-4.patch",
                "Issue #3200711: cannot add an action to a condition": "https://www.drupal.org/files/issues/2021-05-15/cannot_add_action-3200711-29.patch",
                "Issue #3123554: Execution of scheduled tasks is completely broken": "https://www.drupal.org/files/issues/2021-08-13/business_rules-schedule_task_execution_broken-3123554-11.patch",
                "Issue #3056302: Variables placed in email body not being replaced with actual value": "https://www.drupal.org/files/issues/2020-01-21/collect_variables-3056302-11.patch",
                "Issue #3087989: Duplicate condition": "https://www.drupal.org/files/issues/2020-02-06/duplicate-condition-3087989-3.patch",
                "Issue #3250592: Class RedirectResponse not found": "https://www.drupal.org/files/issues/2021-11-22/3250592-class-redirect-response-missing.patch",
                "Issue #3202890: Notice: Trying to access array offset on value of type null": "https://www.drupal.org/files/issues/2022-04-06/send-email-action-access-array-offset-on-value-of-type-null-3202890-3.patch",
                "Issue #3027292: HTML format mails showing markup tags": "https://www.drupal.org/files/issues/2022-04-06/html-format-mails-3027292-19.patch",
                "Issue #3095392: Set multiple fields values": "https://www.drupal.org/files/issues/2022-04-11/set-multiple-fields-value-action-3095392-11.patch",
                "Issue #3067571: Variable evaluation is skipped when multiple events are processed within a single request": "https://www.drupal.org/files/issues/2022-04-12/business_rules-variables_evaluation_skipped-3067571-13.patch",
                "Issue #3257814: implode() Error": "https://www.drupal.org/files/issues/2022-01-21/implode-error-3257814-5.patch",
                "Issue #3274409: Show a system message action is not rendred": "https://www.drupal.org/files/issues/2022-04-11/show-a-system-message-action-is-not-rendred-3274409-2.patch",
                "Issue #3135986: Only build matrix for flowchart when needed": "https://www.drupal.org/files/issues/2020-05-12/business_rules-lazy-matrix-3135986-2.patch",
                "Issue #3277915: Exception with flowchart on condition when used with commerce_br module": "https://www.drupal.org/files/issues/2022-05-04/exception-flowchart-matrix-position-not-empty-3277915-3.patch",
                "Issue #3283637: You have requested a non-existent service business_rules.processor": "https://www.drupal.org/files/issues/2022-06-01/requested-non-existent-service-business-rules-processor-3283637-2.patch",
                "Issue #3314230: PHP 8.1": "https://www.drupal.org/files/issues/2022-10-07/business_rules-php81_deprecation_error-3314230-2.patch",
                "Issue #3298781: PHP 8.1": "https://git.drupalcode.org/project/business_rules/-/merge_requests/9.diff",
                "Issue #3389853: Drupal 10 Compatible": "https://www.drupal.org/files/issues/2023-10-16/Drupal10_Compatible_business_rules-3389853.patch",
                "Local Patch: resolve all D10/PHP 8.1 deprecation errors": "patches/business_rules-php_8.1_deprecaation_errors.patch"
            },

Thanks for the list @lexsoft! I'm pushing all linked issues in a new branch 3.x one by one so I can give the deserved credit to all contributors.

@lexsoft Could you please share me the contents of patches/business_rules-php_8.1_deprecaation_errors.patch?

All tests ok with latest commits.

@rcodina fantastic work! Going to test this the following week.

Just added empty commit to fix credit.

@lexsoft Thanks for all support!

Automatically closed - issue fixed for 2 weeks with no activity.