I was building a class off entity type on a side project and PHPStan identified that label_count's type as not matching its usage. It is documented as a string but also documented as requiring keys and it is initialized with and expected to be an array.
/**
* A definite singular/plural name of the type.
*
* Needed keys: "singular" and "plural".
*
* @var string|\Drupal\Core\StringTranslation\TranslatableMarkup
*
* @see \Drupal\Core\Entity\EntityTypeInterface::getCountLabel()
*/
protected $label_count = [];
Fix documentation to specify it as an array.
Document it as an array.
n/a
n/a (aligning documentation with usage. protected.)
n/a
Doesn't seem like this is necessary.
Fixed
9.5
It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Seems the points in the thread have been addressed. MR is for 10.0 but should still apply cleanly.
Committed/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.