- last update
about 1 year ago 28,526 pass - 🇺🇸United States jasonawant New Orleans, USA
Attached patch uses patch from 14 with changed protected property name to match that of the Drupal 6 node source plugin here
Two interdiffs for comparison.
- 🇺🇸United States danflanagan8 St. Louis, US
Thanks, @jasonawant!
It looks like you missed updating instances of
$this->cache
to$this->fieldInfo
. - Assigned to jasonawant
- Status changed to Needs work
about 1 year ago 5:24pm 11 July 2023 - 🇺🇸United States jasonawant New Orleans, USA
That I did! Thanks for calling that out. Here's an updated patch and interdiffs.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 5:57pm 11 July 2023 - last update
about 1 year ago 28,526 pass - Status changed to RTBC
about 1 year ago 7:53pm 11 July 2023 - 🇺🇸United States danflanagan8 St. Louis, US
That looks great, @jasonawant. And thanks for the thorough interdiffs as well as the link in #19. I'm going to throw this back to RTBC. Thanks!
- last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - 🇳🇿New Zealand quietone New Zealand
Changing title to state the change being made here.
- last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - 🇳🇿New Zealand quietone New Zealand
I am doing triage on the core RTBC queue → .
The issue summary is clear. The proposed resolution is not correct, this is not using a static cache. It is a simple change so I have updated the issue summary. I read the comments and found that all points have been addressed.
- last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - Status changed to Fixed
about 1 year ago 9:58pm 7 September 2023 - 🇬🇧United Kingdom catch
Above I'd suggested class property or using memory cache, given this is a trait, using MemoryCache is less straightforward, so class property seems fine.
Committed/pushed to 11.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.