Clear Caches button should not be part of Performance form

I'll work on the CR.

Added draft change record https://www.drupal.org/node/3350667 →

Will mark this but think we could change this to a feature request and add test coverage.

I'm not sure whether this needs test coverage or not, but let's check the following:

1. Is there any existing test coverage of the page?

2. Manual testing to confirm there's no visual regression.

#15.1 = There are still references to admin/config/development/performance in BlockInvalidRegionTest and ConfigTranslationCacheTest where the "Clear cache" button is pressed.

#15.2 Attaching screenshots but no visual regression.

Before

After

It is pleasant to find an issue with an up to date issue summary and a short one too! I read the IS and the comments and I find that all the questions have been answered.

I tested the patch, using the steps in the issue summary. I can confirm that the patch fixes the problem. However, this is re-testing the patch on 9.3.x instead of 10.1.x.

I also found other tests that use the 'Clear all caches' button.

$ git grep 'submitForm.*Clear all caches' | awk -F: '{print $1}' | sort -u | nl
     1  core/modules/block/tests/src/Functional/BlockInvalidRegionTest.php
     2  core/modules/config_translation/tests/src/Functional/ConfigTranslationCacheTest.php
     3  core/modules/menu_ui/tests/src/Functional/MenuLinkReorderTest.php

Next, I read the CR. I think it needs some improvement and here is what I found:

• "This could impact any custom or contrib modules using hook_form_alter to modify the Clear Caches button behavior, although there are no known examples at present.". And yet the steps to reproduce show the problem with a contrib module. So, that statement seems to be incorrect. Or, am I missing something?
• "The Clear Caches button". It will be clearer if this uses the actual text of the button, 'Clear all caches'.
• The first sentence should be split into two to make it easier to understand.
• The version field should be completed.

I am tagging for CR update.

I read the patch. Everything looks in order and the comments are easy to understand.

So, this just needs the updates to the CR and then it should be good to go.

@quietone I have updated the CR to address your concerns.

CR changes look good. Hopefully makes it for 10.1

Committed 73c3cea and pushed to 10.1.x. Thanks!

Published the change record.

Automatically closed - issue fixed for 2 weeks with no activity.