Contrib.social

Add Drupal 10 to required drupal version

Open on Drupal.org →
Created on 1 January 2022, almost 3 years ago
Updated 3 March 2023, almost 2 years ago

Problem/Motivation

Currently this packages limits installations to Drupal 8.8 through 9.x, which prevents the module from being installed on a Drupal 10 installation, without aliasing Drupal Core and relate packages as a Drupal 9 version.

Steps to reproduce

  • Require drupal/admin_toolbar in a Drupal 10 project with composer without aliasing Drupal 10, or
    • Alias Drupal Core and related modules at Drupal 9.x (pick your version), and subsequently attempt to enable the module.

Proposed resolution

Add Drupal 10 to composer.json and add ^10 to each module's .info.yml file's "core_version_requirement" parameter.

✨ Feature request
Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States lhridley

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇫🇮Finland merilainen

    What about deprecated code? There are at least two problems which upgrade status reports:

    Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

    in SearchLinks.php and ExtraLinks.php

  • Comment almost 2 years ago →
    🇫🇮Finland jheinon_finland

    As mErilainen stated above, there really was some deprecated code in the aforementioned classes SearchLinks.php and ExtraLinks.php.

    In this, the change for adding the missing accessCheck is included as well as the interdiff file between the original patch and the newer patch.

  • Comment almost 2 years ago →
    🇪🇪Estonia hkirsman

    D10 support has been added already to 3.x dev version. The last commit seems to be done in https://www.drupal.org/project/admin_toolbar/issues/3338408 📌 Resolve access check errors for D10 compatibility Needs review

    This particular issue seems done.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024