Patch at #2 could not apply in version 2.4, here is an updated version.
- last update
over 1 year ago 1 pass, 3 fail - Status changed to Needs work
over 1 year ago 6:30am 28 April 2023 - 🇦🇺Australia imclean Tasmania
This creates a hard dependencies on another contrib module so it's unlikely to be considered for inclusion.
It would be better to detect if the other module is present and conditionally add support. Also, there are a few different SVG image modules.
- 🇮🇳India shani maurya Mumbai
I have added the condition to skip the SVG image file validate for the Image Widget Crop Entity Form Display. and it is working fine for me.
- Status changed to Needs review
over 1 year ago 8:13am 13 September 2023 - last update
over 1 year ago CI aborted - last update
over 1 year ago 4 pass - last update
over 1 year ago 4 pass - last update
over 1 year ago 4 pass - 🇫🇷France O'Briat Nantes
You need patch 2 or3 plus 5 in order to fix the problem.
But I'm agree that this dependency is no a good solution.
As I understand it,
SvgImageWidget
overridesImageWidget
through thesvg_image_field_widget_info_alter
hook.
ItsformElement
method adds the svg extensions in$element['#upload_validators']['file_validate_extensions'][0]
But
ImageCropWidget
is not aware of this and implementImageWidget
removing the svg override...Maybe it should be the svg_image module that alter the
file_validate_extensions
though another way (hook) ? - Status changed to Needs work
over 1 year ago 4:42pm 18 September 2023 - 🇩🇪Germany hosterholz
The patch from #3 does not work with svg_image 3.1.0. Here is an adjusted patch.