Fix possibly undefined $finished in _batch_process()

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

#4 is working for me on 10.1.x-dev
SS attached.

Phpstan issues fixed

Fixed

1. +++ b/core/includes/batch.inc
   @@ -32,6 +32,7 @@
   +  $response = [];
   

   FALSE is default value, looking at usage

2. +++ b/core/includes/batch.inc
   @@ -249,6 +250,7 @@ function _batch_progress_page() {
   +  $old_set = [];
   

   no need just fix usage

Fix CS

thanks, baseline was added in #3190406: Update PHPStan to level 1 →

No worries, just doing the easy stuff.
You're the one doing the actual hard work... :)

- Code changes make sense
- TestBot is mostly green, failures seem "normal" random ones.

Seems like a nice PHPStan baseline clean-up, RTBC for me.

Committed/pushed to 10.1.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.