- ๐บ๐พUruguay jjose.quevedo
jjose.quevedo โ made their first commit to this issueโs fork.
- First commit to issue fork.
- last update
over 1 year ago 9 pass, 4 fail - Status changed to Needs review
over 1 year ago 2:38pm 24 July 2023 - last update
over 1 year ago 22 fail - last update
over 1 year ago 22 fail - ๐บ๐พUruguay jjose.quevedo
Here is a patch to solve the issue. Please take a look
The last submitted patch, 8: resolve_translation.patch, failed testing. View results โ
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 1 year ago 11 pass - last update
over 1 year ago 22 fail - Status changed to Needs work
over 1 year ago 7:12pm 24 July 2023 - last update
over 1 year ago 11 pass - ๐ท๐บRussia Chi
Besides
UrlExtractor
there is also aUriExtractor
services. Does it have to be updated same way? - First commit to issue fork.
Chi is right and I pushed the corresponding changes into the MR.
- First commit to issue fork.
- heddn Nicaragua
Updated test coverage (and fixed a failing test) to cover this new feature. I'd mark RTBC, but I wrote too much test coverage.
- ๐ท๐บRussia Chi
Changing constructor signature could break existing sites that extends these services. Though the should not be considered as public API.
Anyway, I propose we change this the next major release. I've just created 4.x branch. - ๐ท๐บRussia Chi
I am thinking of making all TT services
final
to avoid such issues in feature.